Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for the new OmegaConfLoader #2177

Merged
merged 12 commits into from
Jan 10, 2023
Merged

Add docs for the new OmegaConfLoader #2177

merged 12 commits into from
Jan 10, 2023

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Jan 5, 2023

Description

  • Docs to describe the new OmegaConfLoader added in Add OmegaConfLoader #2085
  • I also added a paragraph explaining how to directly set configuration on a config loader class instance

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@merelcht merelcht requested a review from yetudada as a code owner January 5, 2023 14:00
@merelcht merelcht self-assigned this Jan 5, 2023
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht force-pushed the docs/omegaconfloader branch from 878a997 to 34472d3 Compare January 5, 2023 14:01
@merelcht merelcht requested review from stichbury and idanov January 5, 2023 14:02
## Configuration with OmegaConf

[OmegaConf](https://omegaconf.readthedocs.io/) is a python library for dealing with configuration. It is a YAML based hierarchical configuration system, with support for merging configurations from multiple sources.
From Kedro 0.18.5 you can use the [`OmegaConfLoader`](/kedro.config.OmegaConfLoader) which uses `OmegaConf` under the hood to load data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Kedro 0.18.5 you can use the OmegaConfLoader which uses OmegaConf under the hood to load data.

Does this mean it's not yet available? So we'd put docs out ahead of feature going into a release? Does it make sense to flag that you need the development version of kedro and explain how to get it?

merelcht and others added 3 commits January 6, 2023 09:49
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@stichbury stichbury added the Component: Documentation 📄 Issue/PR for markdown and API documentation label Jan 6, 2023
@merelcht merelcht linked an issue Jan 9, 2023 that may be closed by this pull request
merelcht and others added 4 commits January 9, 2023 09:51
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht requested a review from stichbury January 9, 2023 16:40
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@merelcht merelcht merged commit 24500eb into main Jan 10, 2023
@merelcht merelcht deleted the docs/omegaconfloader branch January 10, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs for new OmegaConfLoader
3 participants