-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation ahead of build-docs deprecation #2304
Conversation
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
…r level H1->H3 Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
This has been a more painful PR than I had hoped, but it's ready for review now, and I'd appreciate your thoughts @idanov , @merelcht and @astrojuanlu. I am happy with my approach and think it's better to teach Sphinx basics but i'd love your opinions. |
Notice we can enable the Pull Request Builder on RTD. For that, someone with proper permissions on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @stichbury, made a first round of comments.
Overall, I feel we could try to
- separate more clearly the advice for new projects vs migrating old ones,
- make the migration less scary or disruptive, and
- have a more clear stance towards MyST, even if it requires installing additional extensions
I now know what |
- Put deprecation of `kedro build-docs` inside a warning admonition - Clarify role of existing files and avoid deletion of `docs/source` contents - Clarify that other documentation systems exist - Make Sphinx commands forward and backward compatible - Clarify steps for Markdown documentation - Replace autosummary by regular autodoc Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
@astrojuanlu Please could you take a final look through? I made a commit on top of yours just to revise the wording a little. I also changed the layout of the warning boxes to match those we use throughout our docs. Thanks again for your help on this, it was definitely 🤯 PS: HTML version is here https://stichbury.github.io/tutorial/package_a_project.html |
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
…github.com/kedro-org/kedro into 2114-documentation-about-build-docs-update
Co-authored-by: Juan Luis Cano Rodríguez <hello@juanlu.space>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks perfect to me now 💯 Thanks @stichbury!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These docs are very clear and concise! I appreciate it must have been hard to document the setup this concisely, so fantastic work ⭐ Hopefully our users agree that this is easy to follow 🙂
Signed-off-by: Jo Stichbury jo_stichbury@mckinsey.com
Description
This PR resolves #2114
Development notes
I removed all mention of
build-docs
except to refer back to it as legacy in the section about packaging a project (in the tutorial) I explained how to build docs with Sphinx instead. This was more painful than I anticipated.After a few exploratory attempts, I decided the best way to guide readers wasn't to reproduce what we have been doing with Sphinx in
build-docs
but to advise users on on how to use Sphinx as they would if they weren't provided with any template. So I described how to usesphinx-quickstart
with the latest version of Sphinx (otherwise it gets really tough since we use an old old version, and that itself means we have to fiddle with the version of Jinja2 and all kinds of other sh1t).So I explain how to make a basic Sphinx config, how to add markdown and how to configure autodoc to build docstrings. I don't go into details of using the RTD theme or further extensions.
You can see the built version of the docs here: https://stichbury.github.io/tutorial/package_a_project.html
This can be committed now, once reviewed, but there is follow up work for Kedro 0.19. We need to remove the docs dependencies in setup.py:
also we need remove the code for build-docs, and we need to update the project template/starter to remove the
docs/source
subfolder so there's no existingconf.py
andindex.rst
to confuse things (then we can update these docs again).I also think we should add basic documentation into the project template as to how to create docs (put a markdown folder in the /docs folder maybe) that echoes this advice on using Sphinx.
Note to reviewers
You can see the built version of these changes on my repo. The main changes are on this page.
Checklist
RELEASE.md
file