Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs with plural kedro run flags (load_versions, tags, nodes) #2315

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

ankatiyar
Copy link
Contributor

Signed-off-by: Ankita Katiyar ankitakatiyar2401@gmail.com

Description

Resolves #2246
Documentation for changes introduced in #2301 and #2303

Development notes

Docs changed in the following places -

  • The kedro run options table in docs/source/development/commands_reference.md
  • The config.yml example updated to use comma separated values instead of list format with the new flags in docs/source/kedro_project_setup/configuration.md
  • A kedro run command that used node flag in the spaceflights tutorial docs/source/tutorial/create_a_pipeline.md

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for the update 🌟

| `kedro run --async` | Load and save node inputs and outputs asynchronously with threads |
| `kedro run --env=<env_name>` | Run the pipeline in the env_name environment. Defaults to local if not provided |
| [DEPRECATED] `kedro run --tag=<tag_name1>,<tag_name2>` | Run only nodes which have any of these tags attached. <br /> Multiple instances allowed. |
| `kedro run --tags=<tag_name1>,<tag_name2>` | Run only nodes which have any of these tags attached. <br /> NOTE: This flag will be deprecated in `Kedro 0.19.0`. Use the following flag `--tags` instead. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the note is on the wrong line here. It should be in the for above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I put it in the wrong place. Made the change in dd12b68

node_names:
- node1
- node2
nodes_names: node1, node2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: This will end up being changed back to node_names but better to have the change here as is, as the format of the command changes too.

@AhdraMeraliQB AhdraMeraliQB self-requested a review February 14, 2023 17:24
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ankatiyar ankatiyar merged commit ea31631 into main Feb 16, 2023
@ankatiyar ankatiyar deleted the docs/plural-run-flags branch February 16, 2023 17:51
stichbury pushed a commit that referenced this pull request Feb 28, 2023
…nodes`) (#2315)

* Update docs with plural flags

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

* Move deprecation note to the right place

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

---------

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change docs to use plural flags in kedro run suggestions and examples
4 participants