Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OmegaConfigLoader returns Dict instead of DictConfig, resolves runtime_params properly #2467

Merged
merged 25 commits into from
May 11, 2023
Merged

OmegaConfigLoader returns Dict instead of DictConfig, resolves runtime_params properly #2467

merged 25 commits into from
May 11, 2023

Commits on Feb 10, 2023

  1. Merge branch 'main' of github.com:kedro-org/kedro 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    4565684 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Merge branch 'main' of github.com:kedro-org/kedro 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    67cff2d View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Merge branch 'main' of github.com:kedro-org/kedro 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    055124e View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Merge branch 'main' of github.com:kedro-org/kedro 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    842e83c View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Fix typehint 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    d6d224a View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. test push 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    78c1ae0 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Merge branch 'main' of github.com:kedro-org/kedro into fix-omegaconfig 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    5b48003 View commit details
    Browse the repository at this point in the history

  2. POC of fix to solve the runtime param resolution problem 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    5b0bff8 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Merge branch 'main' of github.com:kedro-org/kedro into fix-omegaconfig 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 2, 2023
    Configuration menu
    Copy the full SHA
    c864783 View commit details
    Browse the repository at this point in the history

  2. Fix OmegaConfigLoadaer - resolve runtime_params early 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 2, 2023
    Configuration menu
    Copy the full SHA
    2c9da40 View commit details
    Browse the repository at this point in the history

  3. Delegate the intialization of runtime_params to AbstractConfigLoader 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 2, 2023
    Configuration menu
    Copy the full SHA
    f578c39 View commit details
    Browse the repository at this point in the history

  4. Add test for interpolated value and globals 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 2, 2023
    Configuration menu
    Copy the full SHA
    de98e15 View commit details
    Browse the repository at this point in the history

  5. add more test and linting 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 2, 2023
    Configuration menu
    Copy the full SHA
    4c0571d View commit details
    Browse the repository at this point in the history

  6. refactor 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 2, 2023
    Configuration menu
    Copy the full SHA
    f1c1ec2 View commit details
    Browse the repository at this point in the history

  7. update release note 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 2, 2023
    Configuration menu
    Copy the full SHA
    acbde3e View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Apply comments and refactor the test 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 4, 2023
    Configuration menu
    Copy the full SHA
    87a51b6 View commit details
    Browse the repository at this point in the history

  2. Update RELEASE.md 

    Co-authored-by: Antony Milne <49395058+antonymilne@users.noreply.github.com>
    @noklam @antonymilne
    noklam and antonymilne authored May 4, 2023
    Configuration menu
    Copy the full SHA
    a1b5f0c View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Remove unnecessary condition when len(config) == 1 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 5, 2023
    Configuration menu
    Copy the full SHA
    29f62ff View commit details
    Browse the repository at this point in the history

  2. Update release note 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 5, 2023
    Configuration menu
    Copy the full SHA
    f610010 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix-omegaconfig

    @noklam
    noklam authored May 5, 2023
    Configuration menu
    Copy the full SHA
    5799792 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Merge branch 'main' into fix-omegaconfig

    @noklam
    noklam authored May 10, 2023
    Configuration menu
    Copy the full SHA
    78c2371 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix-omegaconfig' of github.com:kedro-org/kedro into fix… 

    …-omegaconfig

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 10, 2023
    Configuration menu
    Copy the full SHA
    e24fbfe View commit details
    Browse the repository at this point in the history

  3. Remove unused import 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 10, 2023
    Configuration menu
    Copy the full SHA
    0f7911f View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. remove a line from coverage temporarily 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 11, 2023
    Configuration menu
    Copy the full SHA
    e7d6f62 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-omegaconfig

    @noklam
    noklam authored May 11, 2023
    Configuration menu
    Copy the full SHA
    a4d9893 View commit details
    Browse the repository at this point in the history