#2456 Make incremental data loading lazy #2497
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2456
The implementation of the load function for the
PartitionedDataSet
andIncrementalDataSet
do not match for no apparent reason (one is lazy loaded the other is eager loaded). See #2456.Development notes
This is a breaking change. I have not yet adjusted the release file because I do not know if the implemented behavior is really the wanted behavior. If everything looks good I can prepare the release notes. Another alternative for this issue would be to introduce a boolean
eager
parameter to the PartitionedDataSet and let the user decide if the dataset should be eager or lazy loaded.Checklist
RELEASE.md
file