Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

micropkg packaging improvements #2614

Merged
merged 15 commits into from
Jun 13, 2023
Merged

micropkg packaging improvements #2614

merged 15 commits into from
Jun 13, 2023

Commits on Jun 13, 2023

  1. Make kedro micropkg package accept --verbose 

    Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
    @astrojuanlu
    astrojuanlu committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    e737197 View commit details
    Browse the repository at this point in the history

  2. Improve error when micropkg pull does not find sdist 

    Fix gh-2542.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
    @astrojuanlu
    astrojuanlu committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    726d6f2 View commit details
    Browse the repository at this point in the history

  3. Stop using pkg_resources 

    Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
    @astrojuanlu
    astrojuanlu committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    66120c7 View commit details
    Browse the repository at this point in the history

  4. Do not rely on setup.py to generate sdist 

    See gh-2414.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
    @astrojuanlu
    astrojuanlu committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    1456b8e View commit details
    Browse the repository at this point in the history

  5. Stop relying on .egg-info directories 

    Fix gh-2567.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
    @astrojuanlu
    astrojuanlu committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    8dfe103 View commit details
    Browse the repository at this point in the history

  6. Note change from pkg_requirements 

    See pypa/packaging#644 (comment)

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
    @astrojuanlu
    astrojuanlu committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    f945f7a View commit details
    Browse the repository at this point in the history

  7. Improve code comments 

    Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
    @astrojuanlu
    astrojuanlu committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    10e24c8 View commit details
    Browse the repository at this point in the history

  8. Fix equality checks of equivalent requirements 

    Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
    @astrojuanlu
    astrojuanlu committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    e2a64f7 View commit details
    Browse the repository at this point in the history

  9. Add micropackaging improvements to release notes 

    Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
    @astrojuanlu
    astrojuanlu committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    8625ec5 View commit details
    Browse the repository at this point in the history

  10. Revert sdist check to make it more testable 

    Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
    @astrojuanlu
    astrojuanlu committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    7b74dac View commit details
    Browse the repository at this point in the history

  11. Fix micropkg pull error handling 

    Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
    @astrojuanlu
    astrojuanlu committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    d797acf View commit details
    Browse the repository at this point in the history

  12. Add tests for new micropkg pull branches 

    Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
    @astrojuanlu
    astrojuanlu committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    23541bf View commit details
    Browse the repository at this point in the history

  13. Remove untested path of private code 

    Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
    @astrojuanlu
    astrojuanlu committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    f39a024 View commit details
    Browse the repository at this point in the history

  14. Fix micropkg tests 

    Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
    @astrojuanlu
    astrojuanlu committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    5387918 View commit details
    Browse the repository at this point in the history

  15. Add more detailed explanation of Requirement custom subclass 

    Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
    @astrojuanlu
    astrojuanlu committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    254badc View commit details
    Browse the repository at this point in the history