Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Dataset factories - Eager resolving approach #2632

Closed
wants to merge 6 commits into from

Conversation

ankatiyar
Copy link
Contributor

@ankatiyar ankatiyar commented Jun 2, 2023

Description

Resolve #2423 This PR is introduces the dataset factories feature. This implementation demonstrates the eager resolving of catalog approach.

Development notes

TO DO:

  • Documentation
  • Tests
  • Update kedro catalog list function

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
@ankatiyar ankatiyar changed the title [Draft] Dataset factories [Draft] Dataset factories - Eager resolving approach Jun 2, 2023
ankatiyar and others added 3 commits June 2, 2023 15:35
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
@ankatiyar ankatiyar requested a review from merelcht June 5, 2023 10:11
ankatiyar added 2 commits June 6, 2023 17:26
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
@ankatiyar
Copy link
Contributor Author

Closing this in favour of the lazy resolving approach. #2635

@ankatiyar ankatiyar closed this Jun 8, 2023
@ankatiyar ankatiyar deleted the dataset-factories branch June 29, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate the need of having all datasets defined in the catalog
1 participant