Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Typo in cli help #2737

Merged
merged 4 commits into from
Jun 28, 2023
Merged

FIX: Typo in cli help #2737

merged 4 commits into from
Jun 28, 2023

Conversation

debugger24
Copy link
Contributor

@debugger24 debugger24 commented Jun 28, 2023 •
edited
Loading

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@debugger24 debugger24 requested a review from idanov as a code owner June 28, 2023 09:42
astrojuanlu
astrojuanlu approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @debugger24! Could you please signoff the commit and force push to make the DCO bot happy?

@noklam noklam enabled auto-merge (squash) June 28, 2023 10:02
@noklam noklam disabled auto-merge June 28, 2023 10:04
debugger24 and others added 3 commits June 28, 2023 14:57
@debugger24
FIX: Typo in cli help
cded6a2 
Signed-off-by: debugger24 <rahulcomp24@gmail.com>
@noklam @debugger24
Make GitPod works (kedro-org#2688)
a2ee7a1 
* update base image

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

* update gitpod image and apt-get

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

* update docker

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
---------

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: debugger24 <rahulcomp24@gmail.com>
@deepyaman @astrojuanlu @debugger24
Remove DeprecatedClassMeta in favor of getattr (kedro-org#2724)
aca5dd8 
* Complete build requirements

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Add timeout for e2e process waiting

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Remove DeprecatedClassMeta in favor of getattr

Fix kedro-org/kedro-starters#137

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Ignore deprecation warnings in our own code

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

---------

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: debugger24 <rahulcomp24@gmail.com>
@astrojuanlu astrojuanlu enabled auto-merge (squash) June 28, 2023 14:35
@astrojuanlu astrojuanlu merged commit 931366f into kedro-org:main Jun 28, 2023
@debugger24 debugger24 deleted the patch-2 branch June 28, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noklam noklam noklam approved these changes

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@idanov idanov Awaiting requested review from idanov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@debugger24 @astrojuanlu @noklam @deepyaman