Add documentation for preview datasets in Kedro-viz #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashidakanchwala
requested review from
yetudada,
astrojuanlu and
stichbury
as code owners
astrojuanlu
reviewed
Jul 6, 2023
Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
stichbury
reviewed
Jul 6, 2023
stichbury
reviewed
Jul 6, 2023
stichbury
reviewed
Jul 6, 2023
stichbury
reviewed
Jul 6, 2023
stichbury
reviewed
Jul 6, 2023
stichbury
suggested changes
Jul 6, 2023
There was a problem hiding this comment.
LGTM. Just a few changes requested, mostly just small fixes to capitalisation but also please can you specify the version from which this is supported? I've made some suggestions for how to do this but you'll need to drop in the version to replace the two places I used whatever_it_is to represent the first version supporting the functionality.
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
NeroOkwa
reviewed
Jul 7, 2023
| * `pandas.ExcelDataset` | ||
|
|
||
|
|
||
| To enable the preview of these datasets, you need to add the `preview_args` attribute to the `kedro-viz` configuration under the `metadata` section in the Data Catalog: |
There was a problem hiding this comment.
Can we also state that nrow is number of rows to be previewed?
NeroOkwa
approved these changes
Jul 7, 2023
NeroOkwa
approved these changes
Jul 10, 2023
jmnunezd
pushed a commit
to jmnunezd/kedro
that referenced
this pull request
Jul 11, 2023
Add documentation for preview datasets in Kedro-viz Signed-off-by: Jose <jmnunezd123@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add documentation for preview datasets in Kedro-viz
Development notes
Checklist
RELEASE.mdfile