Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-1466] Sped up initialization of SparkHiveDataSet #281

Closed
wants to merge 7 commits into from

Conversation

MigQ2
Copy link
Contributor

@MigQ2 MigQ2 commented Mar 10, 2020

Description

Implements changes described in #279

Checklist

  • [ X] Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • [ X] Updated the documentation to reflect the code changes
  • [ X] Added a description of this change and added my name to the list of supporting contributions in the RELEASE.md file
  • Added tests to cover my changes

Notice

  • [ X] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@MigQ2 MigQ2 requested review from idanov and tsanikgr as code owners March 10, 2020 13:12
@lorenabalan lorenabalan changed the title Sped up initialization of SparkHiveDataSet [KED-1466] Sped up initialization of SparkHiveDataSet Mar 13, 2020
@deepyaman
Copy link
Member

Super minor note... think it should be "Speed up..." to maintain common tense on the commit messages.

@andrii-ivaniuk
Copy link
Contributor

A separate PR was created.

@mzjp2
Copy link
Contributor

mzjp2 commented May 21, 2020

Hi @MigQ2, thanks for raising this PR! 🙌

We noticed that it branched off from a now pretty old version of the codebase and figured it'd be easier to take the changes you made and put it in the right place ourselves, with full credit to yourself in the contributor notes, of course! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants