Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pip-tools requirement from ~=6.5 to >=6.5,<8.0 #2813

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 18, 2023

Updates the requirements on pip-tools to permit the latest version.

Release notes

Sourced from pip-tools's releases.

7.0.0

Backwards Incompatible Changes:

Features:

Bug Fixes:

Changelog

Sourced from pip-tools's changelog.

7.0.0 (2023-07-14)

Backwards Incompatible Changes:

Features:

Bug Fixes:

6.14.0 (2023-06-28)

Features:

  • Support config defaults using .pip-tools.toml or pyproject.toml (#1863). Thanks @​j00bar
  • Log a warning if the user specifies -P and the output file is present but empty (#1822). Thanks @​davidmreed
  • Improve warning for pip-compile if no --allow-unsafe was passed (#1867). Thanks @​chrysle

Other Changes:

6.13.0 (2023-04-07)

Features:

  • Add support for self-referential extras (#1791). Thanks @​q0w
  • Add support for pip==23.1 where removed FormatControl in WheelCache (#1834). Thanks @​atugushev
  • Add support for pip==23.1 where refactored requirement options

... (truncated)

Commits
  • 60ac79b Release 7.0.0 (#1911)
  • 33667e3 Default to --resolver=backtracking (#1897)
  • 776c3fa Add support for pip==23.2 where removed DEV_PKGS (#1906)
  • 4b9cc32 Merge pull request #1901 from webknjaz/maintenance/gha-reusable-qa
  • d8e302b 🎨🔧👷 Wire in linters into the main workflow
  • 1db8ddd Merge pull request #1899 from webknjaz/maintenance/gha-reusable-ci-on-cron
  • 9c87b0e 👷 Deduplicate cron GHA through workflow reuse
  • 52698a4 Merge pull request #1900 from webknjaz/maintenance/gha-check-v1.2.2
  • 105487c ⇪👷 Bump re-actors/alls-green to v1.2.2
  • 6ae1efc Promote a discord chat on pypa/pip-tools (#1841)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [pip-tools](https://github.com/jazzband/pip-tools) to permit the latest version.
- [Release notes](https://github.com/jazzband/pip-tools/releases)
- [Changelog](https://github.com/jazzband/pip-tools/blob/main/CHANGELOG.md)
- [Commits](jazzband/pip-tools@6.5.0...7.0.0)

---
updated-dependencies:
- dependency-name: pip-tools
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from merelcht as a code owner July 18, 2023 09:06
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 18, 2023
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #2807

Also I'm so happy that dependabot works on pyproject.toml just fine 🤩

@merelcht
Copy link
Member

Are the e2e tests on python 3.7 failures legit? It's the same error on both and I don't think I've seen it before..

@astrojuanlu
Copy link
Member

Ughhhh yeah, looks like the newest pip-tools version requires a newer pip as well... https://github.com/jazzband/pip-tools/#versions-and-compatibility

We'll need to adjust the CI, adjust our deps, or both.

@merelcht
Copy link
Member

@astrojuanlu e2e tests are also failing on #2808 with the same error.. so might be something else?

@astrojuanlu
Copy link
Member

@merelcht There were pip and pip-tools releases very close in time so I'm not sure what's going on, but yes - CI on main is broken ATM

@noklam noklam self-requested a review July 18, 2023 12:19
@noklam
Copy link
Contributor

noklam commented Jul 18, 2023

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@astrojuanlu
Copy link
Member

Right, thanks. This means that pip-tools 7.0 added support for pip 23.2, and previous versions break with the message we're observing.

More evidence that we need to update the upper version cap of pip-tools

@@ -28,7 +28,7 @@ dependencies = [
"more_itertools~=9.0",
"omegaconf~=2.3",
"parse~=1.19.0",
"pip-tools>=6.5,<8.0",
"pip-tools>=7.0,<8.0", # pip==23.2 is a breaking change that requires pip-tools>=7.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should touch the lower bound. After all, there might be environments with old pip versions, right?

pip-tools already takes care of pinning pip appropriately

https://github.com/jazzband/pip-tools/blob/963642811c93a32cdaf730e8226d0fe091391882/pyproject.toml#L41

@astrojuanlu
Copy link
Member

Another part of what's happening is that pip-tools 7, which fixed the bug for pip 23.2, is not available for Python 3.7. They dropped support 2 weeks ago jazzband/pip-tools#1879

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 24, 2023

A newer version of pip-tools exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@astrojuanlu
Copy link
Member

Should we close this PR and focus on #2816 for now @noklam ?

@noklam noklam closed this Jul 24, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 24, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/pip-tools-gte-6.5-and-lt-8.0 branch July 24, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants