Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pip<23.2 and skip one micropkg test to unblock CI from breaking changes #2816

Closed
wants to merge 17 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .circleci/continue_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,9 @@ commands:
# are best handled by conda-installing instead of pip-installing them.
# Dependency resolution works best when installing these altogether in one
# `conda install` command rather than one at a time in several sequential `conda install`s.
- run:
name: Install pip setuptools
command: conda activate kedro_builder; make install-pip-setuptools
- run:
name: Install GDAL, Fiona and pytables
command: conda activate kedro_builder; conda install gdal fiona pytables -c conda-forge -y
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ clean:
pre-commit clean || true

install-pip-setuptools:
pip install -U "pip>=21.2" "setuptools>=65.5.1" wheel
python -m pip install -U "pip>=21.2, <23.2" "setuptools>=65.5.1" wheel

lint:
pre-commit run -a --hook-stage manual $(hook)
Expand Down
1 change: 1 addition & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

## Bug fixes and other changes
* Consolidated dependencies and optional dependencies in `pyproject.toml`.
* Pin `pip<23.2` for CI due to a breaking change. See https://github.com/kedro-org/kedro/pull/2813

## Documentation changes

Expand Down
2 changes: 1 addition & 1 deletion features/environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def _setup_minimal_env(context):
"pip",
"install",
"-U",
"pip>=21.2",
"pip>=21.2, <23.2", # pip==23.2 breaks pip-tools 7.0 and not support Python 3.7
"setuptools>=65.5.1",
"wheel",
],
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def _collect_requirements(requires):
"pyspark>=2.2, <4.0",
"pytest-cov~=3.0",
"pytest-mock>=1.7.1, <2.0",
"pytest-xdist[psutil]~=2.2.1",
"pytest-xdist[psutil]",
"pytest~=7.2",
"redis~=4.1",
"requests-mock~=1.6",
Expand Down
9 changes: 9 additions & 0 deletions tests/framework/cli/micropkg/test_micropkg_package.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import sys
import tarfile
import textwrap
from pathlib import Path
Expand All @@ -15,6 +16,10 @@
TOO_SHORT_ERROR = "It must be at least 2 characters long."


@pytest.mark.skipif(
sys.platform.startswith("win") and sys.version_info < (3, 10, 0),
reason="Due to unknown bug in Window Python < 3.10",
)
@pytest.mark.usefixtures("chdir_to_dummy_project", "cleanup_dist")
class TestMicropkgPackageCommand:
def assert_sdist_contents_correct(
Expand Down Expand Up @@ -490,6 +495,10 @@ def test_micropkg_package_nested_module(
assert f"{PIPELINE_NAME}/pipeline.py" not in sdist_contents


@pytest.mark.skipif(
sys.platform.startswith("win") and sys.version_info < (3, 10, 0),
reason="Due to unknown bug in Window Python < 3.10",
)
@pytest.mark.usefixtures(
"chdir_to_dummy_project", "cleanup_dist", "cleanup_pyproject_toml"
)
Expand Down
2 changes: 1 addition & 1 deletion tools/circleci/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
pip>=21.2
pip>=21.2, <23.2
setuptools>=65.5.1
twine~=3.0