-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.11 support to Kedro #2851
Merged
Merged
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
d605b9c
add 3.11
SajidAlamQB 3bf65ec
Merge branch 'main' into feat/add-python-3.11-support
SajidAlamQB 8eb4e01
Update setup.py
SajidAlamQB a130680
Merge branch 'main' into feat/add-python-3.11-support
SajidAlamQB d4e16e6
limit number of python version tests
SajidAlamQB 8500cd3
Merge branch 'main' into feat/add-python-3.11-support
SajidAlamQB afb7fe0
Merge branch 'main' into feat/add-python-3.11-support
SajidAlamQB 0a614f3
fix setup.py
SajidAlamQB ae3218c
delta-spark version
SajidAlamQB 98382aa
try original setup
SajidAlamQB 43fe722
remove 3.11 from circleci
SajidAlamQB a846b5d
Update setup.py
SajidAlamQB c465dbd
Update setup.py
SajidAlamQB 449667e
pin matplotlib to 3.7.2 for python 3.11
SajidAlamQB 61e3943
Update test_import.py
SajidAlamQB eb87de9
add noks test adjustments
SajidAlamQB 137b0ea
Update setup.py
SajidAlamQB f0ed4b7
Update setup.py
SajidAlamQB f866f02
replace eq with is for multi_catalog
SajidAlamQB 1dfdd57
minor fixes
SajidAlamQB 8fbd316
remove matplotlib 3.11 pin
SajidAlamQB cf41741
matplotlib pin for 3.11
SajidAlamQB 0b19f6b
run original matplotlib pin with ubuntu only
SajidAlamQB 69ebb0f
run circleci
SajidAlamQB 286f7e6
pin spark < 3.4 as its breaking
SajidAlamQB 0bcaf20
Merge branch 'main' into feat/add-python-3.11-support
SajidAlamQB cde0fac
spark datasets revert earlier changes back to original
SajidAlamQB 728a6b1
delta
SajidAlamQB 39e9fbc
remove all windows tests from GHA
SajidAlamQB 263352e
skip coverage as not needed
SajidAlamQB dabe065
Checking only WIN tests (will revert)
SajidAlamQB 4aa2243
Update unit-tests.yml
SajidAlamQB 9c80517
undo previous commit
SajidAlamQB f86c850
add msbuild
SajidAlamQB be90f73
add ubuntu tests back in and remove 3.11 tests from circleci add in m…
SajidAlamQB 12e1082
set hdf5 disable check and lint
SajidAlamQB 85f4e91
pin tables for 3.8
SajidAlamQB 52af1e6
pin 3.8 tables
SajidAlamQB a8202f6
lint
SajidAlamQB e2c41ff
remove 3.11 completely from circleci and tidy up
SajidAlamQB 02e2924
add 3.11 to pyarrow pin for docs
SajidAlamQB 0a221c5
undo previous commit
SajidAlamQB 4f74950
update rtd to python 3.11
SajidAlamQB 6e847cb
try 3.10 on rtd
SajidAlamQB 9b4e14d
fix outdated pylint to ruff
SajidAlamQB 8d9b74e
changes based on review
SajidAlamQB 94eccb1
add mock for pyarrow and deltalake for docs
SajidAlamQB bb664a5
undo previous commit
SajidAlamQB 03331fa
Merge branch 'main' into feat/add-python-3.11-support
SajidAlamQB cbadaae
Update setup.py
SajidAlamQB 83d5782
Update .readthedocs.yml
SajidAlamQB a044743
Merge branch 'main' into feat/add-python-3.11-support
SajidAlamQB 6951fbe
Update conf.py
SajidAlamQB dbdf4d1
Merge branch 'feat/add-python-3.11-support' of https://github.com/ked…
SajidAlamQB 2413b78
changes based on review
SajidAlamQB ac40d05
fix comments
SajidAlamQB 5c39c10
test running 3.10 parallel
SajidAlamQB 55b4076
Merge branch 'main' into feat/add-python-3.11-support
SajidAlamQB 5f06f7c
Add to release notes and update badges on docs
SajidAlamQB 9a54714
Add migration tips
SajidAlamQB 014fe36
Merge branch 'main' into feat/add-python-3.11-support
SajidAlamQB ff936c9
Merge branch 'main' into feat/add-python-3.11-support
SajidAlamQB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am surprise you don't need to add 3.11 here. Does that means test can be run in parallel for 3.11? Or is it because the
moto
version is now upgrade so we don't need to handle 3.10 specially anymore?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new
moto
version now allows for parallel test execution for Python 3.10. I believe before when we added 3.10 supportmoto
newer version broke parallel tests for 3.10 hence it was made sequential but I believe with the newermoto
version we have pinned this has resolved the issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's amazing! 🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Good that I asked. This is great, I have look into the s3fs repository and basically they have to use the server mode for
moto
to run tests. The newer version ofmoto
seems supporting this better and potentially we can unblock this ticket.