-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move default template to static pyproject.toml
, take 2
#2853
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d1ee941
Remove leftover reference to micropkg setup.py
astrojuanlu 9b3e636
Replace outdated extras requirement with kedro-datasets
astrojuanlu 83010f6
Remove outdated mention to environment.yml
astrojuanlu edc32ce
Move flake8 configuration to dedicated file
astrojuanlu 4c87a75
Replace setup.py with pyproject.toml in default project template
astrojuanlu 6c1c4be
Adapt link to moving file in docs
astrojuanlu 97524f6
Revert "Replace outdated extras requirement with kedro-datasets"
astrojuanlu e9c6137
Add release notes for pyproject.toml change
astrojuanlu 21616ba
Merge branch 'main' into template-static-pyproject-take-2
astrojuanlu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
features/steps/test_starter/{{ cookiecutter.repo_name }}/.flake8
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[flake8] | ||
max-line-length = 88 | ||
extend-ignore = E203 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 0 additions & 5 deletions
5
features/steps/test_starter/{{ cookiecutter.repo_name }}/setup.cfg
This file was deleted.
Oops, something went wrong.
31 changes: 31 additions & 0 deletions
31
features/steps/test_starter/{{ cookiecutter.repo_name }}/src/pyproject.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
[build-system] | ||
requires = ["setuptools"] | ||
build-backend = "setuptools.build_meta" | ||
|
||
[project] | ||
name = "{{ cookiecutter.python_package }}" | ||
version = "0.1" | ||
dynamic = ["dependencies"] | ||
|
||
[tool.setuptools.packages.find] | ||
exclude = ["tests"] | ||
|
||
[project.scripts] | ||
{{ cookiecutter.repo_name }} = "{{ cookiecutter.python_package }}.__main__:main" | ||
|
||
[project.optional-dependencies] | ||
docs = [ | ||
"docutils<0.18.0", | ||
"sphinx~=3.4.3", | ||
"sphinx_rtd_theme==0.5.1", | ||
"nbsphinx==0.8.1", | ||
"nbstripout~=0.4", | ||
"sphinx-autodoc-typehints==1.11.1", | ||
"sphinx_copybutton==0.3.1", | ||
"ipykernel>=5.3, <7.0", | ||
"Jinja2<3.1.0", | ||
"myst-parser~=0.17.2", | ||
] | ||
|
||
[tool.setuptools.dynamic] | ||
dependencies = {file = "requirements.txt"} |
39 changes: 0 additions & 39 deletions
39
features/steps/test_starter/{{ cookiecutter.repo_name }}/src/setup.py
This file was deleted.
Oops, something went wrong.
File renamed without changes.
31 changes: 31 additions & 0 deletions
31
kedro/templates/project/{{ cookiecutter.repo_name }}/src/pyproject.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
[build-system] | ||
requires = ["setuptools"] | ||
build-backend = "setuptools.build_meta" | ||
|
||
[project] | ||
name = "{{ cookiecutter.python_package }}" | ||
version = "0.1" | ||
dynamic = ["dependencies"] | ||
|
||
[tool.setuptools.packages.find] | ||
exclude = ["tests"] | ||
|
||
[project.scripts] | ||
{{ cookiecutter.repo_name }} = "{{ cookiecutter.python_package }}.__main__:main" | ||
|
||
[project.optional-dependencies] | ||
docs = [ | ||
"docutils<0.18.0", | ||
"sphinx~=3.4.3", | ||
"sphinx_rtd_theme==0.5.1", | ||
"nbsphinx==0.8.1", | ||
"nbstripout~=0.4", | ||
"sphinx-autodoc-typehints==1.11.1", | ||
"sphinx_copybutton==0.3.1", | ||
"ipykernel>=5.3, <7.0", | ||
"Jinja2<3.1.0", | ||
"myst-parser~=0.17.2", | ||
] | ||
|
||
[tool.setuptools.dynamic] | ||
dependencies = {file = "requirements.txt"} |
39 changes: 0 additions & 39 deletions
39
kedro/templates/project/{{ cookiecutter.repo_name }}/src/setup.py
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently this has no effect in preventing the warning (then turned into an error) 🤔 Will ignore it for now