-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "runtime_params" resolver to allow overriding of config with CLI params #3036
Merged
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f782ee4
Add runtime_params resolver
ankatiyar 6d7fdd0
Update globals, runtime_params resolver + Add tests
ankatiyar 069348d
Add docs, release notes, update test and error condition
ankatiyar 2ece3aa
Move table of contents
stichbury 5312e06
Apply suggestions from code review
ankatiyar dab29ef
Merge branch 'main' into runtime-params-resolver
ankatiyar eb5aa58
Update RELEASE.md
ankatiyar 8cefc6f
Apply suggestions from code review
ankatiyar 14b087b
Suggestions from code review
ankatiyar 8937cf7
Make globals work with bypassed config
ankatiyar 1dd0d03
Fix broken link
ankatiyar d892e6f
Merge branch 'main' into runtime-params-resolver
ankatiyar baaa3cf
Apply suggestions from code review
ankatiyar 495488a
fix lint
ankatiyar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have a comment explaining why we treat global differently.