Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fix for Shareable Kedro-viz. #3099

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

rashidakanchwala
Copy link
Contributor

@rashidakanchwala rashidakanchwala commented Sep 29, 2023

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Updated to docs to reflect the correct fsspec the user needs to download which is fsspec[s3] which will also download 's3fs' dependency.

Development notes

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@astrojuanlu
Copy link
Member

Could you please signoff your commit so the DCO check passes? If you click on it you will find instructions. If it was only one commit you can do git commit --amend --signoff --no-edit, if you had more, git rebase --signoff. After rewriting the history you will need to do git push --force.

And if you keep working on this branch, please use the -s/--signoff flag when committing, for example git commit -s -m 'Add feature'.

@astrojuanlu astrojuanlu enabled auto-merge (squash) September 29, 2023 14:45
Signed-off-by: Rashida Kanchwala <rashida.kanchwala@quantumblack.com>
@rashidakanchwala rashidakanchwala force-pushed the doc/quick-command-fix-shareable-viz-docs branch from 3927cac to f6fe8f7 Compare September 29, 2023 15:25
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@astrojuanlu astrojuanlu merged commit bbed0f1 into main Sep 29, 2023
18 checks passed
@astrojuanlu astrojuanlu deleted the doc/quick-command-fix-shareable-viz-docs branch September 29, 2023 15:39
@astrojuanlu
Copy link
Member

Sorry that was my stored reply for signoffs 🥹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants