Include new libraries at requirements.txt in spaceflights tutorial tutorial_template.md #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laizaparizotto
requested review from
yetudada,
astrojuanlu and
stichbury
as code owners
ankatiyar
reviewed
Oct 6, 2023
I just ran the spaceflight tutorial and this part of the documentation seems to be outdated. Only small detail. Signed-off-by: Laiza Parizotto <laizamsparizotto@gmail.com>
Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Signed-off-by: Laiza Parizotto <laizamsparizotto@gmail.com>
laizaparizotto
force-pushed
the
update_spaceflights_documentation_take_2
branch
from
1551c46
to
492601e
Compare
laizaparizotto
force-pushed
the
update_spaceflights_documentation_take_2
branch
from
0d2c63d
to
f257c35
Compare
|
The spaceflights tutorial has recently been updated to use |
Sync documentation with source code at https://github.com/kedro-org/kedro-starters/blob/main/spaceflights/%7B%7B%20cookiecutter.repo_name%20%7D%7D/src/requirements.txt Signed-off-by: Laiza Parizotto <laizamsparizotto@gmail.com>
laizaparizotto
force-pushed
the
update_spaceflights_documentation_take_2
branch
from
a888e10
to
9b70c77
Compare
|
@merelcht Indeed the corrections from this PR were not matching that link. They are now :D |
merelcht
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
I left one more suggestion, but otherwise this looks good! Thanks for the contribution @laizaparizotto ⭐
Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: Laiza Parizotto <laizamsparizotto@gmail.com>
laizaparizotto
force-pushed
the
update_spaceflights_documentation_take_2
branch
from
8291492
to
6f7bf89
Compare
|
Thank you @merelcht |
merelcht
requested review from
ankatiyar
and removed request for
astrojuanlu,
stichbury and
yetudada
stichbury
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Thank you for improving our spaceflights project yet again @laizaparizotto 🌟
ankatiyar
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sorry, here is the corrected version from PR #3117.
Development notes
Checklist
RELEASE.mdfile