[Ready] Changes to improve existing content about notebook development & kedro #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
stichbury
added
the
Component: Documentation 📄
|
|
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
stichbury
changed the title
stichbury
requested review from
deepyaman,
merelcht,
AhdraMeraliQB and
ankatiyar
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
SajidAlamQB
approved these changes
Oct 11, 2023
astrojuanlu
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Sorry for the delayed review, this somehow fell through the cracks.
I think this PR is an improvement over what we had before and it's ready to go in. However, I also believe that the real game changer for this page will be de-emphasizing custom kernels, de-emphasizing kedro jupyter, and placing more emphasis in %load_ext kedro.ipython, as I suggested in this other issue #2777
That can be done in a separate PR so LGTM 👍🏽
ankatiyar
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Built docs are here
This answers #2845 by improving the content of the documentation page that describes how to combine a Kedro project with notebooks for data exploration. It also removes the
standalone-datacatalogpage which was ill-advised as it's not really about notebooks (I've moved it temporarily into the README for the starter).This is part of a pair of PRs (#3128 is the other) to revise notebook docs. This one describes the "Add a notebook to Kedro projects" workflow, while #3128 describes the "Add Kedro to a notebook" workflow. They meet in the middle but I've separated them because I didn't want any one PR getting too complex.
Development notes
Changes to screenshots and copy.
Checklist
RELEASE.mdfile