-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs on difference between OmegaConf
and OmegaConfigLoader
#3352
Conversation
…ples Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
OmegaConf
and OmegaConfigLoader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor changes to address Vale feedback and simplify the read but TBH all are suggestions and feel free to ignore some, all or none.
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com> Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are great, thank you. Two minor typo fixes (which also address a Vale moan) but approving as a fantastic job. Thanks for the updates 🌟
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com> Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Description
Fixes #3247
Development notes
Added docs to address:
Added examples for:
For reviewers
The thing I struggled with for these docs is where to put them. I've added them all to the configuration docs, but I'm not sure if it really fits here, because this is actually part of the whole story of using Kedro as a library vs Framework.
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file