Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Minor issues/improvements to pyproject.toml #3426

Merged
merged 25 commits into from
Dec 20, 2023

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented Dec 14, 2023

Description

Context: #3333

Development notes

  • QoL changes and adding examples to pyproject.toml

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@SajidAlamQB SajidAlamQB self-assigned this Dec 14, 2023
@SajidAlamQB SajidAlamQB linked an issue Dec 14, 2023 that may be closed by this pull request
@SajidAlamQB SajidAlamQB changed the title Tools: Minor issues/improvements Tools: Minor issues/improvements to pyproject.toml Dec 14, 2023
@SajidAlamQB SajidAlamQB marked this pull request as draft December 14, 2023 13:45
SajidAlamQB and others added 10 commits December 19, 2023 19:12
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
…#3424)

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
* remove example pipeline requirements

Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>

* lint

Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>

* simplify amending kedro[...] lines

Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>

* keep the version for datasets

Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>

* lint

Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>

---------

Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
* Sort `requirements.txt` based on package name only

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* Remove now-unused custom `requirements.txt` sorter

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* Ruff format kedro/templates/project/hooks/utils.py

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* Pass the right argument to `fix_requirements` call

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* Add `sort_requirements` until starters are updated

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* Wrap lib call in existing method for compatibility

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

---------

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
This reverts commit f4a4a15.

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@AhdraMeraliQB AhdraMeraliQB marked this pull request as ready for review December 19, 2023 19:14
AhdraMeraliQB and others added 7 commits December 20, 2023 10:40
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@AhdraMeraliQB AhdraMeraliQB marked this pull request as draft December 20, 2023 12:00
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Ahdra Merali added 3 commits December 20, 2023 12:19
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@AhdraMeraliQB AhdraMeraliQB marked this pull request as ready for review December 20, 2023 13:14
kedro/framework/cli/starters.py Outdated Show resolved Hide resolved
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AhdraMeraliQB 🚀

@AhdraMeraliQB AhdraMeraliQB merged commit fc9b70b into main Dec 20, 2023
30 checks passed
@AhdraMeraliQB AhdraMeraliQB deleted the dev/tools-minor-bug-fixes branch December 20, 2023 16:39
AhdraMeraliQB added a commit that referenced this pull request Dec 22, 2023
* Update test starter pyprojet file

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Add example_pipeline to cookiecutter file

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

---------

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add-ons: Minor issues/improvements
6 participants