Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CITATION.cff to be the same as the TSC list in the docs #3565

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

merelcht
Copy link
Member

Description

Resolves #3412

Development notes

As explained in #3412 there are no rules or guidelines about who should/shouldn't be mentioned as authors in a citation file. I think it's easiest to maintain this list to make authors equal to TSC members. So the list in the citation file should always be the same as https://docs.kedro.org/en/stable/contribution/technical_steering_committee.html#current-maintainers

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@stichbury
Copy link
Contributor

I noticed that @astrojuanlu has an orcid ID listed but nobody else does. I think we should be consistent and list everybody's or nobody's, right?

Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changes, thanks @merelcht 🌟

@astrojuanlu
Copy link
Member

ORCiD is a very academic thing, I have it because I wanted to track other scientific work in the old days 😅 unsure if it's worth forcing everyone to create one, but I'm not opposed of course.

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏽

@stichbury
Copy link
Contributor

stichbury commented Jan 29, 2024

ORCiD is a very academic thing, I have it because I wanted to track other scientific work in the old days 😅 unsure if it's worth forcing everyone to create one, but I'm not opposed of course.

I'm aware of what it is; I have my own and would imagine there are other team members that do too. And for that reason, in the interest of consistency, I think either all TSC members that have one should have their ID included or none. It's gone down for maintenance right now but when it comes back I'll check to see who else needs adding.

Edit later: I've added Yetunde, myself and I'm checking with Dmitry on whether the one I've found for his name is his.

stichbury and others added 3 commits January 29, 2024 14:25
Adding in two more ORCiD fields. May be one more to come (just checking with Dmitry)

Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
@stichbury stichbury enabled auto-merge (squash) February 1, 2024 14:51
@stichbury stichbury merged commit eb3b416 into main Feb 1, 2024
28 checks passed
@stichbury stichbury deleted the update-citation-cff branch February 1, 2024 15:12
@noklam noklam mentioned this pull request Feb 27, 2024
7 tasks
@merelcht merelcht mentioned this pull request Apr 11, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update authors in CITATION.cff
3 participants