%load_node experiments #3568
Merged
%load_node experiments #3568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
AhdraMeraliQB
force-pushed
the
ahdra/load-node-experiments
branch
from
306c98d to
45ec09c
Compare
added 15 commits
February 1, 2024 08:26
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
This reverts commit 63ee194. Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
This reverts commit ad63afc. Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
This reverts commit 04c022e. Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
AhdraMeraliQB
force-pushed
the
ahdra/load-node-experiments
branch
from
5b9ddb1 to
4581373
Compare
AhdraMeraliQB
merged commit 5d3b898
into
2009-create-line-magic-to-debug-a-node-in-notebook-workflow
2 checks passed
AhdraMeraliQB
added a commit
that referenced
this pull request
Feb 1, 2024
* Simplify mocking Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Check node func names Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Naive fix for return statements Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Handle nested case Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Change pipelines fixture type Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Remove unnecessary TODO Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Revert "Check node func names" This reverts commit 63ee194. Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Replace commented return statements with a display() statement Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add warning about node name when node not found Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add line about debugging inputs in catalog Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Lint Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Change wording Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Revert "Replace commented return statements with a display() statement" This reverts commit ad63afc. Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Revert "Naive fix for return statements" This reverts commit 04c022e. Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update tests Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> --------- Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
noklam
added a commit
that referenced
this pull request
Feb 2, 2024
* update notes Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * add some basic structure for the debugging magic Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * add demo code Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * lint Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * implement the _find_node and _prepare_node_inputs function Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * implement _prepare_imports Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * clean up the import function to use the real function Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * separate the cells into different part Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * update dependencies Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * add test structure Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * Lint Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add some tests and placeholders Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add more tests Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Even more tests Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * And more tests Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Remove placeholders Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * test remove condition Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * add more dcostring Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * add logs Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * refactor the test and fix imports Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * more tests fixed Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * refacto tests with list of string with """ Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * Fix node Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * replace test with triple quotes string Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * rename function to the _prepare pattern Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * fix more test Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * skip tests Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * Lint Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add ipylab to test requirements Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Fix missing syntax Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Apply suggestion from code review Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Remove redundant TODOs Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Fix handling node with lambda function Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Try pin pluggy Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * refactor the find_node method with pipeline as argument and tests Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * Update kedro/ipython/__init__.py Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * Re-import mocked object Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Remove try-catch Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Rename overwritten varaible Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add warnings and simplify tests (#3568) * Simplify mocking Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Check node func names Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Naive fix for return statements Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Handle nested case Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Change pipelines fixture type Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Remove unnecessary TODO Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Revert "Check node func names" This reverts commit 63ee194. Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Replace commented return statements with a display() statement Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add warning about node name when node not found Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add line about debugging inputs in catalog Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Lint Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Change wording Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Revert "Replace commented return statements with a display() statement" This reverts commit ad63afc. Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Revert "Naive fix for return statements" This reverts commit 04c022e. Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update tests Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> --------- Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add universal warnings Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * Change to copy full function definition instead of just function body Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * 1 down, 4 more tests to fix Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * fix extra empty space Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * fix tests Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * Update release notes and some typos Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> --------- Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> Co-authored-by: Ahdra Merali <90615669+AhdraMeraliQB@users.noreply.github.com> Co-authored-by: Ahdra Merali <ahdra.merali@quantumblack.com> Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds: