Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for installation latest Kedro #3589

Merged
merged 5 commits into from
Feb 3, 2024
Merged

Update README.md for installation latest Kedro #3589

merged 5 commits into from
Feb 3, 2024

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Feb 2, 2024

Description

Add a section for installation from source. We used to have nightly build(?), this is mainly for advance user who are willing to try out the latest Kedro which is not released yet. It would be nice to have a section to point them to.

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
@noklam noklam requested a review from merelcht as a code owner February 2, 2024 16:46
@noklam noklam changed the title Update README.md Update README.md for installation latest Kedro Feb 2, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated
Comment on lines 42 to 46
```
git clone git@github.com:kedro-org/kedro.git
cd kedro
pip install .
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I suggest that you split this into two, so the git clone command, then the text "Change to the kedro directory and enter the following: pip install ."

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor suggestions but it looks good to me.

stichbury and others added 3 commits February 2, 2024 16:53
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam noklam requested a review from stichbury February 2, 2024 17:36
@noklam
Copy link
Contributor Author

noklam commented Feb 2, 2024

Thanks, add a sentence to explain why is it useful.

README.md Outdated Show resolved Hide resolved
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@@ -37,6 +37,12 @@ conda install -c conda-forge kedro

Our [Get Started guide](https://docs.kedro.org/en/stable/get_started/install.html) contains full installation instructions, and includes how to set up Python virtual environments.

### Installation from source
To access the latest Kedro version before its official release, install it from the `main` branch.
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```bash

Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟 Thanks @noklam

@noklam noklam merged commit aa907cd into main Feb 3, 2024
9 checks passed
@noklam noklam deleted the noklam-patch-1 branch February 3, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants