-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin pip
version and bump actions versions
#3598
Conversation
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
🤞🏽 |
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
pip
version and bump actions versions
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
…npin-pip Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone through the Release note of pip
Normalize extras according to PEP 685 from package metadata in the resolver for comparison. This ensures extras are correctly compared and merged as long as the package providing the extra(s) is built with values normalized according to the standard. Note, however, that this does not solve cases where the package itself contains unnormalized extra values in the metadata. (#11649)
Noted the original problem was related to the unnormalised extra names we have in kedro-datasets
. I suspect the tests passed here because we don't have dataset extras in kedro
anymore. So I suggest when you try to make the same changes in kedro-datasets
, make sure things like kedro-datasets[all]
will work as expected, right now I think it will most likely fail.
@@ -12,7 +12,7 @@ jobs: | |||
runs-on: ubuntu-latest | |||
steps: | |||
- name: Checkout | |||
uses: actions/checkout@v3 | |||
uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the node 16 actions have been deprecated by Github Actions and the new versions of these actions have transitioned to node 20 (https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/)
I'm trying it out on |
Description
Partially fix kedro-org/kedro-plugins#674
(Also needs to be updated on
kedro-plugins
in a separate PR)pip
released a new version -> https://pypi.org/project/pip/24.0/Development notes
Update versions of checkout, setup-python, and setup-msbuild actions
unpin
pip
versionDeveloper Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file