-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide better error message outside of a kedro project #3680
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3ebd73c
provide error message outside of kedro project with rich style
noklam b434fef
change to add custom click message on error instead of overriding get…
noklam 302fe7b
add test
noklam 7eff977
clean up
noklam c528711
catch the error message from click
noklam 79ef7d1
fix unitests
noklam 194dfd1
Update error message
noklam 07f5472
move color constant to the upper module
noklam b3c3949
fix imports
noklam 1324ebc
Merge branch 'main' into noklam/provide-better-error-message-1829
noklam 520d8da
release note
noklam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
"""``kedro.framework.cli`` implements commands available from Kedro's CLI. | ||
""" | ||
|
||
from .cli import main | ||
from .utils import command_with_verbosity, load_entry_points | ||
# The constant need to be defined first otherwise it causes circular depdencies | ||
ORANGE = (255, 175, 0) | ||
BRIGHT_BLACK = (128, 128, 128) | ||
|
||
from .cli import main # noqa: E402 | ||
from .utils import command_with_verbosity, load_entry_points # noqa: E402 | ||
|
||
__all__ = ["main", "command_with_verbosity", "load_entry_points"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these go in
kedro.utils
? So you wouldn't have to define them first.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can, but I think
cli
is the correct scope as this only affect CLI color. Alternative is keep it incli/cli.py
because this is the only file that get used at the moment.