Fix tests #4149
Merged
Fix tests #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
ElenaKhaustova
merged commit c7efa3e
into
4110-move-pattern-resolution-logic
2 checks passed
ElenaKhaustova
added a commit
that referenced
this pull request
Sep 12, 2024
…nent (#4123) * Added a skeleton for AbstractDataCatalog and KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed from_config method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented _init_datasets method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented get dataset Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Started resolve_patterns implementation Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented resolve_patterns Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed credentials resolving Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated match pattern Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented add from dict method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated io __init__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added list method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented _validate_missing_keys Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added datasets access logic Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added __contains__ and comments on lazy loading Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed dataset_name to ds_name Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated some docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed _update_ds_configs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed _init_datasets Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented add_runtime_patterns Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed runtime patterns usage Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Moved pattern logic out of data catalog, implemented KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * KedroDataCatalog updates Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added property to return config Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added list patterns method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed and moved ConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed ConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Cleaned KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Cleaned up DataCatalogConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Docs build fix attempt Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated from_config method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated constructor and add methods Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated _get_dataset method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated __contains__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated __eq__ and shallow_copy Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added __iter__ and __getitem__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed unused imports Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added TODO Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated runner.run() Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated session Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added confil_resolver property Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog list command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog create command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog rank command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog resolve command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Remove some methods Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed ds configs from catalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed lint Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed typo Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added module docstring Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed None from Pattern type Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs failing to find class reference Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs failing to find class reference Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated Patterns type Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fix tests (#4149) * Fix most tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Fix most tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Returned constants to avoid breaking changes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Minor fix Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated test_sorting_order_with_other_dataset_through_extra_pattern Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed odd properties Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed None from _fetch_credentials input Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed DataCatalogConfigResolver to CatalogConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed _init_configs to _resolve_config_credentials Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Moved functions to the class Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Refactored resolve_dataset_pattern Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed refactored part Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Changed the order of arguments for DataCatalog constructor Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Replaced __getitem__ with .get() Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog commands Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Moved warm up block outside of the try block Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed linter Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed odd copying Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> --------- Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
ElenaKhaustova
added a commit
that referenced
this pull request
Sep 17, 2024
* Added a skeleton for AbstractDataCatalog and KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed from_config method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented _init_datasets method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented get dataset Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Started resolve_patterns implementation Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented resolve_patterns Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed credentials resolving Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated match pattern Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented add from dict method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated io __init__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added list method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented _validate_missing_keys Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added datasets access logic Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added __contains__ and comments on lazy loading Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed dataset_name to ds_name Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated some docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed _update_ds_configs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed _init_datasets Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented add_runtime_patterns Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed runtime patterns usage Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Moved pattern logic out of data catalog, implemented KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * KedroDataCatalog updates Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added property to return config Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added list patterns method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed and moved ConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed ConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Cleaned KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Cleaned up DataCatalogConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Docs build fix attempt Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated from_config method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated constructor and add methods Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated _get_dataset method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated __contains__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated __eq__ and shallow_copy Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added __iter__ and __getitem__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed unused imports Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added TODO Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated runner.run() Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated session Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added confil_resolver property Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog list command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog create command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog rank command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog resolve command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Remove some methods Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed ds configs from catalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed lint Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed typo Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added module docstring Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed None from Pattern type Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs failing to find class reference Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs failing to find class reference Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated Patterns type Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fix tests (#4149) * Fix most tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Fix most tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Returned constants to avoid breaking changes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Minor fix Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated test_sorting_order_with_other_dataset_through_extra_pattern Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed odd properties Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed None from _fetch_credentials input Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed DataCatalogConfigResolver to CatalogConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed _init_configs to _resolve_config_credentials Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Moved functions to the class Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Refactored resolve_dataset_pattern Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed refactored part Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Changed the order of arguments for DataCatalog constructor Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Replaced __getitem__ with .get() Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog commands Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Moved warm up block outside of the try block Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed linter Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed odd copying Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated release notes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Returned DatasetError Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added _dataset_patterns and _default_pattern to _config_resolver to avoid breaking change Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Made resolve_dataset_pattern return just dict Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed linter Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added Catalogprotocol draft Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented CatalogProtocol Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated types Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed linter Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added _ImplementsCatalogProtocolValidator Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Excluded Potocol from coverage Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed reference to DataCatalog in docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed add_all from protocol Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated RELEASE.md Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> --------- Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
ElenaKhaustova
added a commit
that referenced
this pull request
Sep 24, 2024
* Added a skeleton for AbstractDataCatalog and KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed from_config method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented _init_datasets method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented get dataset Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Started resolve_patterns implementation Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented resolve_patterns Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed credentials resolving Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated match pattern Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented add from dict method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated io __init__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added list method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented _validate_missing_keys Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added datasets access logic Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added __contains__ and comments on lazy loading Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed dataset_name to ds_name Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated some docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed _update_ds_configs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed _init_datasets Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented add_runtime_patterns Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed runtime patterns usage Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Moved pattern logic out of data catalog, implemented KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * KedroDataCatalog updates Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added property to return config Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added list patterns method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed and moved ConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed ConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Cleaned KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Cleaned up DataCatalogConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Docs build fix attempt Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * KedroDataCatalog draft Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated from_config method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated constructor and add methods Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated _get_dataset method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated __contains__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated __eq__ and shallow_copy Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added __iter__ and __getitem__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed unused imports Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added TODO Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated runner.run() Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated session Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added confil_resolver property Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog list command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog create command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog rank command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog resolve command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Remove some methods Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed ds configs from catalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed lint Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed typo Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added module docstring Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renaming methods Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed None from Pattern type Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs failing to find class reference Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs failing to find class reference Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated Patterns type Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fix tests (#4149) * Fix most tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Fix most tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Returned constants to avoid breaking changes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Udapted KedroDataCatalog for recent changes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Minor fix Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated test_sorting_order_with_other_dataset_through_extra_pattern Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed odd properties Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed None from _fetch_credentials input Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated specs and context Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated runners Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated default catalog validation Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated default catalog validation Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated contains and added exists methods for KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixing docs and lint Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed unit tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added __eq__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed DataCatalogConfigResolver to CatalogConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed _init_configs to _resolve_config_credentials Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Moved functions to the class Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Refactored resolve_dataset_pattern Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed refactored part Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Changed the order of arguments for DataCatalog constructor Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Replaced __getitem__ with .get() Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog commands Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Moved warm up block outside of the try block Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed linter Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed odd copying Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed DataCatalogConfigResolver to CatalogConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed AbstractDataCatalog to BaseDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Moved validate_dataset_config inside catalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed _init_dataset to _add_from_config Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fix lint Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated release notes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Returned DatasetError Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added _dataset_patterns and _default_pattern to _config_resolver to avoid breaking change Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Made resolve_dataset_pattern return just dict Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed linter Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added Catalogprotocol draft Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented CatalogProtocol Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated types Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed linter Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added _ImplementsCatalogProtocolValidator Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Excluded Potocol from coverage Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed catalog source to kedro_data_catalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed data set to dataset in docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated add_from_dict Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Revised comments and TODOs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated error message to point to specific catalog type Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Merged with protocol Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed reference to DataCatalog in docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Reordered methods Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed add_all from protocol Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Changed the order of arguments Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added __repr__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Made __getitem__ return deepcopy Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed bug in get_dataset() Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed __eq__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added __setitem__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Unit tests for `KedroDataCatalog` (#4171) * Added KedroDataCatlog tests template Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added test save/load unregistered dataset Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added test_feed_dict Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added exists tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added tests for list() Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added test_eq Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added test init/add datasets Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated test_adding_datasets_not_allowed Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added shallow copy tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added TestKedroDataCatalogFromConfig Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added missing tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> --------- Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated RELEASE.md Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed deep copies Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed some interface that will be changed in the next version Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed key completions Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixinf typos Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed key completions test Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Replaced data set with dataset Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added docstring for get_dataset() method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed pytest fixture Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Addressed review comments Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated _assert_requirements_ok starters test Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Revert "Updated _assert_requirements_ok starters test" This reverts commit 5208321. Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated error message Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Replaced typo Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Replaced data set with dataset in docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Made KedroDataCatalog subclass from CatalogProtocol Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated release notes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed resolve_dataset_pattern to resolve_pattern Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> --------- Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
ElenaKhaustova
added a commit
that referenced
this pull request
Oct 18, 2024
* Added a skeleton for AbstractDataCatalog and KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed from_config method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented _init_datasets method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented get dataset Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Started resolve_patterns implementation Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented resolve_patterns Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed credentials resolving Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated match pattern Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented add from dict method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated io __init__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added list method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented _validate_missing_keys Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added datasets access logic Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added __contains__ and comments on lazy loading Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed dataset_name to ds_name Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated some docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed _update_ds_configs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed _init_datasets Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented add_runtime_patterns Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed runtime patterns usage Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Moved pattern logic out of data catalog, implemented KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * KedroDataCatalog updates Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added property to return config Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added list patterns method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed and moved ConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed ConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Cleaned KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Cleaned up DataCatalogConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Docs build fix attempt Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * KedroDataCatalog draft Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated from_config method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated constructor and add methods Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated _get_dataset method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated __contains__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated __eq__ and shallow_copy Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added __iter__ and __getitem__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed unused imports Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added TODO Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated runner.run() Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated session Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added confil_resolver property Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog list command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog create command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog rank command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog resolve command Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Remove some methods Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed ds configs from catalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed lint Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed typo Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added module docstring Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renaming methods Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed None from Pattern type Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs failing to find class reference Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs failing to find class reference Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated Patterns type Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fix tests (#4149) * Fix most tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Fix most tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Returned constants to avoid breaking changes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Udapted KedroDataCatalog for recent changes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Minor fix Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated test_sorting_order_with_other_dataset_through_extra_pattern Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed odd properties Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed None from _fetch_credentials input Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated specs and context Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated runners Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated default catalog validation Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated default catalog validation Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated contains and added exists methods for KedroDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixing docs and lint Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed unit tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added __eq__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed DataCatalogConfigResolver to CatalogConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed _init_configs to _resolve_config_credentials Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Moved functions to the class Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Refactored resolve_dataset_pattern Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed refactored part Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Changed the order of arguments for DataCatalog constructor Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Replaced __getitem__ with .get() Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated catalog commands Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Moved warm up block outside of the try block Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed linter Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed odd copying Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed DataCatalogConfigResolver to CatalogConfigResolver Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed AbstractDataCatalog to BaseDataCatalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Moved validate_dataset_config inside catalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed _init_dataset to _add_from_config Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fix lint Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated release notes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Returned DatasetError Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added _dataset_patterns and _default_pattern to _config_resolver to avoid breaking change Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Made resolve_dataset_pattern return just dict Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed linter Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added Catalogprotocol draft Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented CatalogProtocol Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated types Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed linter Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added _ImplementsCatalogProtocolValidator Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Excluded Potocol from coverage Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed catalog source to kedro_data_catalog Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed data set to dataset in docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated add_from_dict Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Revised comments and TODOs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated error message to point to specific catalog type Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Merged with protocol Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed reference to DataCatalog in docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Reordered methods Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed add_all from protocol Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Changed the order of arguments Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added __repr__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Made __getitem__ return deepcopy Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed bug in get_dataset() Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed __eq__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added __setitem__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Unit tests for `KedroDataCatalog` (#4171) * Added KedroDataCatlog tests template Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added test save/load unregistered dataset Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added test_feed_dict Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added exists tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added tests for list() Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added test_eq Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added test init/add datasets Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated test_adding_datasets_not_allowed Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added shallow copy tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added TestKedroDataCatalogFromConfig Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added missing tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> --------- Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated RELEASE.md Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed deep copies Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed some interface that will be changed in the next version Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed key completions Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixinf typos Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed key completions test Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Replaced data set with dataset Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added docstring for get_dataset() method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Renamed pytest fixture Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Addressed review comments Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated _assert_requirements_ok starters test Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Revert "Updated _assert_requirements_ok starters test" This reverts commit 5208321. Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated error message Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Replaced typo Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Replaced data set with dataset in docstrings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Made KedroDataCatalog subclass from CatalogProtocol Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated release notes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented iter, getitem, setitem Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated add_data and TODOs Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added key completions Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Maded behavior dict like Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Merged with main Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed add_data() method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added usage example and updated docstrings with experimental feature note Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added len and get Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Implemented unit tests Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Update RELEASE.md Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com> * Update kedro/io/kedro_data_catalog.py Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com> * Fixed lint Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated load_data and save_data to use new interface Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated load_data and save_data to use new interface Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Returned usage of get_dataset() Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed lint Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated __getitem__ to use old get_dataset() method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed regex_search from values() Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed type annotation for __iter__ Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed linter Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Revert lint fix Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Returned short names for save and load Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Removed regex_search from keys and items Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated release notes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Maded regex_search non optional Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Changed default for regex_flags Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Returned list() method Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed __iter__ return type Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> --------- Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com> Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile