-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add databricks asset bundles docs #4265
Conversation
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@@ -0,0 +1,272 @@ | |||
# Use an IDE, dbx and Databricks Repos to develop a Kedro project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not new docs so no need to review, I move the original databricks_ide_developmenet.md
page to a new file and use that file for DAB instead.
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
8eec4ba
to
2733196
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also update the index page https://docs.kedro.org/en/stable/deployment/databricks/index.html and mention asset bundles?
docs/source/deployment/databricks/databricks_ide_development_workflow.md
Outdated
Show resolved
Hide resolved
docs/source/deployment/databricks/databricks_ide_development_workflow.md
Outdated
Show resolved
Hide resolved
docs/source/deployment/databricks/databricks_ide_development_workflow.md
Outdated
Show resolved
Hide resolved
docs/source/deployment/databricks/databricks_ide_development_workflow.md
Outdated
Show resolved
Hide resolved
docs/source/deployment/databricks/databricks_ide_development_workflow.md
Outdated
Show resolved
Hide resolved
docs/source/deployment/databricks/databricks_ide_development_workflow.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Also could be useful to clarify where the user can configure the cluster. For example, I have an existing cluster, but by default |
@astrojuanlu I believe you are trying to run this with our internal Azure Databricks? From my understanding a job cluster is always created fresh.
But it seems like it is also possible to run job on all-purpose cluster,, though it is not recommended. https://docs.databricks.com/en/jobs/compute.html#all-purpose. Is the tricks here using the |
I remember having this problem the first time I tested the plugin and I forgot where did I write down the solution 😂 VS Code is showing me an error because the In fact I think I found a bug: after I tweak the config override, |
Currently the best I could do is to specify the default:
job_clusters:
- job_cluster_key: default
new_cluster:
spark_version: ...
tasks:
- task_key: default
existing_cluster_id: 1111-... # <---- This seems to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a couple more dbx
references
docs/source/deployment/databricks/databricks_ide_development_workflow.md
Outdated
Show resolved
Hide resolved
docs/source/deployment/databricks/databricks_ide_development_workflow.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Sorry for the late response. I see that you have resolved some of the issues by your self. You are correct that you should use Generally, the api for bundle resources follows the schema for creating a new job. See here. |
I have add an existing cluster id section and test it on databricks and added a few more screenshots for the UI flow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, but otherwise this looks great! 👍
Don't forget to add a note in the release notes.
docs/source/deployment/databricks/databricks_ide_development_workflow.md
Outdated
Show resolved
Hide resolved
docs/source/deployment/databricks/databricks_ide_development_workflow.md
Outdated
Show resolved
Hide resolved
docs/source/deployment/databricks/databricks_ide_development_workflow.md
Outdated
Show resolved
Hide resolved
…orkflow.md Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
…orkflow.md Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
docs/source/deployment/databricks/databricks_ide_development_workflow.md
Outdated
Show resolved
Hide resolved
docs/source/deployment/databricks/databricks_ide_development_workflow.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Pull Request is not mergeable
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
In the interest of getting this merged, given that it has 2 approvals already and that @noklam had addressed all the comments, I'm hitting the button. |
Pending redirect
|
Description
Partially #3360
Development notes
kedro-databricks
Build: https://kedro--4265.org.readthedocs.build/en/4265/deployment/databricks/index.html
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file