Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add only_missing option in KedroContext class #60

Closed
wants to merge 2 commits into from
Closed

Add only_missing option in KedroContext class #60

wants to merge 2 commits into from

Conversation

Minyus
Copy link
Contributor

@Minyus Minyus commented Jul 18, 2019

Notice

  • [ x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Motivation and Context

run_only_missing option was missing in KedroContext class introduced by [KED-826] Use KedroContext class in project template (#111)

How has this been tested?

  1. Run kedro new and create a new kedro project including the iris data pipeline.
  2. Modify context.run(tags, runner) to context.run(tags, runner, only_missing=True) in run.py
    image
  3. Run kedro run and confirm the 4 tasks are processed by the logged message.
  4. Run kedro run again and confirm the 4 tasks are not processed again because of the only_missing option.

image

Checklist

  • [x ] Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes
  • Assigned myself to the PR

@lorenabalan
Copy link
Contributor

Hi @Minyus ! Thanks for raising this. However, as discussed under the related issue (#30), the Kedro team does not intend to support this as core functionality. It can, however, now be more easily added in the project's capabilities, thanks to the addition of KedroContext! Please let me know if you have further questions, otherwise I will go ahead and close this PR in a day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants