-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track command usage with telemetry #68
Comments
@noklam
So we can go with Python and use |
For now, I decide to first understand how I realise For the actual telemetry tracking, I prefer to trigger this in TS since we can track the usage of command directly (compare to tracking it from requests to language server indirectly), this is also much easier to extend in the future. In the meantime, I have some conversation with @ravi-kumar-pilla to research on viz's telemetry. I aim to kick start this work this week so we can finished it before the release (1st or 2nd week of September). |
Some information on how Telemetry works internally in Viz -
@noklam lets connect to discuss if this is not clear. Thank you |
If I understand it correctly, So the main "consent" flow is still done in Python, via mimic @app.get("/")
@app.get("/experiment-tracking")
async def index():
heap_app_id = kedro_telemetry.get_heap_app_id(project_path)
heap_user_identity = kedro_telemetry.get_heap_identity() How should I understand this code? Does that mean only the index page will check for consent but not the others? |
This includes everything on viz. All other routes are subpaths |
after finishing framework telemetry opt-out, I created a ticket about consent check and UUID update in viz, some discussion is also there: |
Thanks a lot @ravi-kumar-pilla ! Now I have the full picture of how telemetry would work in the extension. So Heap has 3 ways to track information.
AFAIK, the flowchart currently will not collect telemetry, because it's not served via the To achieve that, we need to implement this in two place:
Cc @jitu5 |
We have download stats but we need a bit more details to help making decision for feature development.
We will introduce
kedro viz
command within the extension, we can add telemetry to get some insight about the usage. From my understanding, viz itself tracks the UI click but it wouldn't be sufficient to tell if it's from VSCode.Questions
Do we implement the telemetry in TS or Python? This may depends on what do we want to track.
Python
Pro:
kedro-telemetry
for consentCon:
TS
Pro:
Con:
The text was updated successfully, but these errors were encountered: