Install fastapi, pydantic and orjson during extension activation & bundle kedro-viz into extension

[jitu5]

Resolves #72

As pydantic and orjson depends on platform and python version, So it cant be packaged with extension so those dependencies are installed during extension activation in Kedro extension env (bundled/libs)

[noklam]

For viz, do we have a particular version that we need to pin? (I think it's the next release version, so we need to wait until it is released, but I just want to confirm this).

[jitu5]

Mostly it would be next release 10.0.0. later we willl pin it

[noklam]

What is this globalState? Does that mean it only install if the dependency is not there? I couldn't find the code where this state is set.

[jitu5]

In a VSCode extension, globalState is an API provided by the VSCode framework that allows you to store and retrieve global state info. This state is persisted across VS Code sessions, it remains available even after VS Code is closed and reopened.

globalState does not have .set method.

Does that mean it only install if the dependency is not there?

No it just check if await installPythonDependencies(context); is called before with alreadyInstalled flag.

[jitu5]

@noklam you mentioned in slack

On client side (TS), we have a function that is callPythonScript
On Python side we keep install_dependencies as a executable script.

Could you please elaborate more this, so that I can make changes accordingly.

[noklam]

I think it's mainly just a refactoring, you have this now:

export async function installPythonDependencies(context: any): Promise<void> {
    return new Promise<void>(async (resolve, reject) => {
        const script = context.asAbsolutePath('bundled/tool/install_dependencies.py');
        const interpreterDetails = await getInterpreterDetails();
        const pythonPath = interpreterDetails['path'] && interpreterDetails['path'][0];

        cp.exec(`${pythonPath} ${script} ${EXTENSION_ROOT_DIR}`, (error, stdout, stderr) => {
            if (error) {
                console.error(stderr);
                reject(error);
            } else {
                console.log(stdout);
                resolve();
            }
        });
    });
}

I was thinking something more like this to make it slightly generic. Frankly it is fine to keep it as is as well.

export async function callPythonScript(context: any, path_to_script: str): Promise<void> {
    return new Promise<void>(async (resolve, reject) => {
        const script = context.asAbsolutePath(path_to_script);
        const interpreterDetails = await getInterpreterDetails();
        const pythonPath = interpreterDetails['path'] && interpreterDetails['path'][0];

        cp.exec(`${pythonPath} ${script} ${EXTENSION_ROOT_DIR}`, (error, stdout, stderr) => {
            if (error) {
                console.error(stderr);
                reject(error);
            } else {
                console.log(stdout);
                resolve();
            }
        });
    });
}

callPythonScript('bundled/tool/install_dependencies.py')

The reason I was thinking this because it is common for extension/LSP to call tools to perform different actions (think black or ruff for linting/formating)

[jitu5]

I think it's mainly just a refactoring, you have this now:

export async function installPythonDependencies(context: any): Promise<void> {
    return new Promise<void>(async (resolve, reject) => {
        const script = context.asAbsolutePath('bundled/tool/install_dependencies.py');
        const interpreterDetails = await getInterpreterDetails();
        const pythonPath = interpreterDetails['path'] && interpreterDetails['path'][0];

        cp.exec(`${pythonPath} ${script} ${EXTENSION_ROOT_DIR}`, (error, stdout, stderr) => {
            if (error) {
                console.error(stderr);
                reject(error);
            } else {
                console.log(stdout);
                resolve();
            }
        });
    });
}

I was thinking something more like this to make it slightly generic. Frankly it is fine to keep it as is as well.

export async function callPythonScript(context: any, path_to_script: str): Promise<void> {
    return new Promise<void>(async (resolve, reject) => {
        const script = context.asAbsolutePath(path_to_script);
        const interpreterDetails = await getInterpreterDetails();
        const pythonPath = interpreterDetails['path'] && interpreterDetails['path'][0];

        cp.exec(`${pythonPath} ${script} ${EXTENSION_ROOT_DIR}`, (error, stdout, stderr) => {
            if (error) {
                console.error(stderr);
                reject(error);
            } else {
                console.log(stdout);
                resolve();
            }
        });
    });
}

callPythonScript('bundled/tool/install_dependencies.py')

The reason I was thinking this because it is common for extension/LSP to call tools to perform different actions (think black or ruff for linting/formating)

@noklam created generic callPythonScript which can be used for other python script run.

[noklam]

Updated the title, all looks good!

[noklam]

Is there anything left to be done here? If not I can merge the PR.

[jitu5]

Is there anything left to be done here? If not I can merge the PR.

@noklam Most of the things are done under this PR. we can merge now.