-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fast node verification #4
base: separate-nodes
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -121,6 +121,14 @@ var ( | |
Name: "disablesnapprotocol", | ||
Usage: "Disable snap protocol", | ||
} | ||
DisableDiffProtocolFlag = cli.BoolFlag{ | ||
Name: "disablediffprotocol", | ||
Usage: "Disable diff protocol", | ||
} | ||
EnableTrustProtocolFlag = cli.BoolFlag{ | ||
Name: "enabletrustprotocol", | ||
Usage: "Enable trust protocol", | ||
} | ||
DiffSyncFlag = cli.BoolFlag{ | ||
Name: "diffsync", | ||
Usage: "Enable diffy sync, Please note that enable diffsync will improve the syncing speed, " + | ||
|
@@ -259,9 +267,11 @@ var ( | |
Usage: "The layer of tries trees that keep in memory", | ||
Value: 128, | ||
} | ||
AllowInsecureNoTriesFlag = cli.BoolTFlag{ | ||
Name: "allow-insecure-no-tries", | ||
Usage: `Disable the tries state root verification, the state consistency is no longer 100% guaranteed, diffsync is not allowed if enabled. Do not enable it unless you know exactly what the consequence it will cause.`, | ||
defaultVerifyMode = ethconfig.Defaults.TriesVerifyMode | ||
TriesVerifyModeFlag = TextMarshalerFlag{ | ||
Name: "tries-verify-mode", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Better description is needed to let users understand the meaning of each mode |
||
Usage: `tries verify mode: "local", "full", "insecure", "none"`, | ||
Value: &defaultVerifyMode, | ||
} | ||
OverrideBerlinFlag = cli.Uint64Flag{ | ||
Name: "override.berlin", | ||
|
@@ -1622,6 +1632,12 @@ func SetEthConfig(ctx *cli.Context, stack *node.Node, cfg *ethconfig.Config) { | |
if ctx.GlobalIsSet(DisableSnapProtocolFlag.Name) { | ||
cfg.DisableSnapProtocol = ctx.GlobalBool(DisableSnapProtocolFlag.Name) | ||
} | ||
if ctx.GlobalIsSet(DisableDiffProtocolFlag.Name) { | ||
cfg.DisableDiffProtocol = ctx.GlobalIsSet(DisableDiffProtocolFlag.Name) | ||
} | ||
if ctx.GlobalIsSet(EnableTrustProtocolFlag.Name) { | ||
cfg.EnableTrustProtocol = ctx.GlobalIsSet(EnableTrustProtocolFlag.Name) | ||
} | ||
if ctx.GlobalIsSet(DiffSyncFlag.Name) { | ||
cfg.DiffSync = ctx.GlobalBool(DiffSyncFlag.Name) | ||
} | ||
|
@@ -1652,8 +1668,18 @@ func SetEthConfig(ctx *cli.Context, stack *node.Node, cfg *ethconfig.Config) { | |
if ctx.GlobalIsSet(TriesInMemoryFlag.Name) { | ||
cfg.TriesInMemory = ctx.GlobalUint64(TriesInMemoryFlag.Name) | ||
} | ||
if ctx.GlobalIsSet(AllowInsecureNoTriesFlag.Name) { | ||
cfg.NoTries = ctx.GlobalBool(AllowInsecureNoTriesFlag.Name) | ||
if ctx.GlobalIsSet(TriesVerifyModeFlag.Name) { | ||
cfg.TriesVerifyMode = *GlobalTextMarshaler(ctx, TriesVerifyModeFlag.Name).(*core.VerifyMode) | ||
// If a node sets verify mode to full or light, it's a fast node and need | ||
// to verify blocks from verify nodes, then it should enable trust protocol. | ||
if cfg.TriesVerifyMode.NeedRemoteVerify() { | ||
cfg.EnableTrustProtocol = true | ||
} | ||
// If a node sets verify mode but not local, it's a fast node whose difflayer is not integral. | ||
// So fast node should disable diff protocol. | ||
if cfg.TriesVerifyMode != core.LocalVerify { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After discuss with nash, we can delete flag |
||
cfg.DisableDiffProtocol = true | ||
} | ||
} | ||
if ctx.GlobalIsSet(CacheFlag.Name) || ctx.GlobalIsSet(CacheSnapshotFlag.Name) { | ||
cfg.SnapshotCache = ctx.GlobalInt(CacheFlag.Name) * ctx.GlobalInt(CacheSnapshotFlag.Name) / 100 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,6 +64,26 @@ func DeleteCanonicalHash(db ethdb.KeyValueWriter, number uint64) { | |
} | ||
} | ||
|
||
func IsTrustBlock(db ethdb.Reader, hash common.Hash) bool { | ||
data, _ := db.Get(trustBlockHashKey(hash)) | ||
if len(data) == 0 { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what about:
We can save the allocation of slices each time, more memory friendly. |
||
return false | ||
} | ||
return bytes.Equal(data,[]byte{byteTrue}) | ||
} | ||
|
||
func MarkTrustBlock(db ethdb.KeyValueWriter, hashkey common.Hash) { | ||
if err := db.Put(trustBlockHashKey(hashkey),[]byte{byteTrue}); err != nil { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suggest define |
||
log.Crit("Failed to store trust block hash") | ||
} | ||
} | ||
|
||
func DeleteTrustBlockHash(db ethdb.KeyValueWriter, hash common.Hash) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Never been used, I think we should delete the storage once we are 100% sure it will not be used any longer. |
||
if err := db.Delete(trustBlockHashKey(hash)); err != nil { | ||
log.Crit("Failed to delete trust block hash") | ||
} | ||
} | ||
|
||
// ReadAllHashes retrieves all the hashes assigned to blocks at a certain heights, | ||
// both canonical and reorged forks included. | ||
func ReadAllHashes(db ethdb.Iteratee, number uint64) []common.Hash { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,6 +93,9 @@ var ( | |
// difflayer database | ||
diffLayerPrefix = []byte("d") // diffLayerPrefix + hash -> diffLayer | ||
|
||
// trust block database | ||
trustBlockPrefix = []byte("trust-block-") // trustBlockPrefix + hash -> verify result | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please delete useless code |
||
|
||
preimagePrefix = []byte("secure-key-") // preimagePrefix + hash -> preimage | ||
configPrefix = []byte("ethereum-config-") // config prefix for the db | ||
|
||
|
@@ -118,6 +121,8 @@ const ( | |
|
||
// freezerDifficultyTable indicates the name of the freezer total difficulty table. | ||
freezerDifficultyTable = "diffs" | ||
// | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Incomplete comment |
||
byteTrue = 0x01 | ||
) | ||
|
||
// FreezerNoSnappy configures whether compression is disabled for the ancient-tables. | ||
|
@@ -164,6 +169,10 @@ func headerTDKey(number uint64, hash common.Hash) []byte { | |
func headerHashKey(number uint64) []byte { | ||
return append(append(headerPrefix, encodeBlockNumber(number)...), headerHashSuffix...) | ||
} | ||
// trustBlockHashKey = trustBlockPrefix + hash | ||
func trustBlockHashKey(hash common.Hash) []byte { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please delete useless code |
||
return append(append(trustBlockPrefix, hash.Bytes()...)) | ||
} | ||
|
||
// headerNumberKey = headerNumberPrefix + hash | ||
func headerNumberKey(hash common.Hash) []byte { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean it is not proper to introduce such low level flag. Especially it is related with other flags.
For example: when
TriesVerifyModeFlag
need trust protocol whileEnableTrustProtocolFlag
is false, it is become complicated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider we should disable diff protocol in verify node, and enable trust protocol, we didn't have better solution temporary.