Refactor source with browserify for browser/server interoperability #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try/catch handles URL limit exceptions add a base64 lib that actually works tests pass for client.addEvent and client.run methods restore examples pages ensure correct behavior for get/post queries
client-side callbacks are changing from 2 success/error functions to a single function with (err, res) arguments. This is intended to match the server-side callbacks, so code written on this library can similarly travel between client and browser without painful shims and conditions
gulp-yui-compressor gulp-rename (post-compress) gulp-gzip
|
@alexkwolfe sorry, I misspoke in our earlier convo - the functionality we discussed has not been ported over here yet (just everything else). We also need to get this new stuff documented. I just opened #209 to continue to convo- |
superagent used directly by core methods cleaned up helpers dir cleaned up core methods
Add unformatted response value to widget title attribute, temp' resolving #206
|
🎉 |
dustinlarimer
pushed a commit
that referenced
this pull request
Jan 2, 2015
Refactor source with browserify for browser/server interoperability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hefty refactor allows the library to run in the browser or on the server. We've replaced grunt w/ gulp, and added a few more tools to handle context-specific builds and tests. Server-side testing is handled with mocha, and browser build are tested w/ PhantomJS, Karma (Chrome, Firefox, Safari), and SauceLabs (iOS, Android, IE9-10).
Breaking changes:
function(err, res){}callback signature.Keen.Visualizationandrequest.draw()have been removed. This is now handled with theKeen.Dataviz, which will take center stage in our documentation and visualization guides.