Pull in code for BLAKE2b hash function #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code and test vectors of Blake2B checksum have been pulled in to this library. It will allow us to define precompiles for Blake2b checksums, if needed. Additionally, we can now test against vectors from RFC instead of autogenerating vectors just for F. I have also modified F implementation removing the loop over block content. According to the RFC, this loop is not a part of F function - see `blake2b_update` C function in the RFC for reference.
All our test vectors for F functions are autogenerated. Since we now test entire checksum, we do not need so many test vectors just for F function. I left less than 20 test vectors, from which we'll generate go-ethereum test cases for F precompile.
This will let us to import only F code from projects that require only F compression function and use govendor to manage dependencies (hello, go-ethereum!)
|
Hey @mhluongo can I ask you for reviewing this PR? |
|
Also looking for another Gopher here @dimpar |
dimpar
approved these changes
Jul 2, 2019
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #2
Closes: #4
In this PR we pull in the code for BLAKE2b hash from
golang.org/x/crypto. This will allow us to add BLAKE2b hash precompile (see https://github.com/ethereum-cat-herders/PM/issues/64) - if needed - using the same library as the one we use ingo-ethereumforFcompression function precompile.Having all the official test vectors for BLAKE2b here allowed getting rid of the autogenerated test vectors for
Fcompression function. I left just a couple of them and added a code transforming them to the same test vector format as the one used ingo-ethereumprecompile tests.The
Fcompression function is placed in a separate package so that we can pull only this function fromgo-ethereumwithgovendor.