Normalize function name to eliminate underscores #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-ethereum ABI code drops leading underscores and transforms function to a camel case. Instead of __beaconCallback, we get beaconCallback. Instead of open_keep, we get openKeep. This commit introduces the same behaviour to our contract code generators.
Shadowfiend
approved these changes
Mar 30, 2020
|
Don't want to merge here until we have a working build using this in keep-core or keep-ecdsa if that seems reasonable @pdyraga ? |
This was referenced Mar 30, 2020
|
Yep, it works as expected - two PRs referenced above use the code from this PR. |
|
Rockin', let's do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-ethereum ABI generator drops underscores and transforms function name to camel case. Instead of
__beaconCallback, we getbeaconCallback. Instead ofopen_keep, we getopenKeep. Here we introduce the same behaviour to our contract code generators.