-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics package #40
Metrics package #40
Conversation
Added metrics package which provides tools useful for gathering and exposing system metrics for external monitoring tools.
Registry level labels are redundant and can cause pointless data-series growth.
Is there an existing package used for similar stuff in any of our existing dependencies? Thinking specifically of libp2p. |
Unfortunately, I didn't find anything fitting our needs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a metrics package provided by go-ethereum
: https://github.com/ethereum/go-ethereum/tree/master/metrics
Is it something we could not use for our needs? If so, can we summarize why for future-us?
If we did not explore this option, I think I am fine merging this PR and looking at go-ethereum
metrics in the future.
Yeah, this PR overlaps several things from |
Added metrics package which provides tools useful for gathering and exposing system metrics for external monitoring tools.