Balance monitoring retries #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package was originally defined in keep-ecdsa repository https://github.com/keep-network/keep-ecdsa/blob/2fdf57d4e61f9dd313fb717c221605b5d812b187/pkg/utils/wrappers.go
We want to use a retry mechanism for single executions of the balance check. The retries will be performed during the period of `retryTimeout`, logging a warning on each error. When the timeout is hit an error will be logged and retries stopped. A next balance check will be triggered at the tick.
nkuba
force-pushed
the
balance-monitoring-retries
branch
from
051d018 to
26fdfa2
Compare
We added a check execution at start of the monitoring. Previously we had to wait for ticker to invoke the first check.
The test checks calls to the balance source function. In the future we should check logged messages.
pdyraga
approved these changes
Sep 2, 2021
| func (bm *BalanceMonitor) Observe( | ||
| ctx context.Context, | ||
| address Address, | ||
| alertThreshold *Token, | ||
| tick time.Duration, | ||
| retryTimeout time.Duration, |
There was a problem hiding this comment.
Non-blocking but shouldn't we validate retryTimeout < tick so that we do not have two checks overlapping?
There was a problem hiding this comment.
On the other hand, don't we want to leave it to the implementation using this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use a retry mechanism for single executions of the balance check.
The retries will be performed during the period of
retryTimeout, logging a warning on each error. When the timeout is hit an error will be logged and retries stopped. The next balance check will be triggered at the next tick.