Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relay request callback #870

Merged
merged 16 commits into from
Jun 21, 2019
Merged

Relay request callback #870

merged 16 commits into from
Jun 21, 2019

Conversation

ngrinkevich
Copy link
Contributor

@ngrinkevich ngrinkevich commented Jun 6, 2019 •
edited by pdyraga
Loading

Closes: #799

Update both Solidity and Go code to provide optional relay request callback.

@ngrinkevich ngrinkevich marked this pull request as ready for review June 6, 2019 01:06
@ngrinkevich ngrinkevich requested review from a team June 6, 2019 01:09
@ngrinkevich
Copy link
Contributor Author

Ready for review @pdyraga

@ngrinkevich
Copy link
Contributor Author

@pdyraga ready for second pass

@ngrinkevich
Copy link
Contributor Author

@pdyraga ready to merge 🚀

pdyraga
pdyraga requested changes Jun 19, 2019
View reviewed changes
pkg/beacon/relay/chain/chain.go Outdated Show resolved Hide resolved
contracts/solidity/test/TestKeepRandomBeaconViaProxy.js Outdated Show resolved Hide resolved
contracts/solidity/scripts/genesis.js Show resolved Hide resolved
contracts/solidity/contracts/KeepRandomBeaconImplV1.sol Outdated Show resolved Hide resolved
contracts/solidity/contracts/KeepRandomBeaconImplV1.sol Show resolved Hide resolved
contracts/solidity/scripts/genesis.js Outdated Show resolved Hide resolved
contracts/solidity/test/TestKeepRandomBeaconCallback.js Outdated Show resolved Hide resolved
contracts/solidity/test/TestKeepRandomBeaconCallback.js Outdated Show resolved Hide resolved
pkg/chain/ethereum/ethereum.go Outdated Show resolved Hide resolved
pkg/chain/local/local.go Outdated Show resolved Hide resolved
@ngrinkevich
Copy link
Contributor Author

@pdyraga all comments addressed!

@ngrinkevich ngrinkevich requested a review from pdyraga June 21, 2019 12:51
pdyraga
pdyraga previously approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@pdyraga pdyraga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question. Need to test now...

pdyraga
pdyraga approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@pdyraga pdyraga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • genesis works from the script
  • relay request works from the script
  • relay request + callback works from the script

@pdyraga pdyraga merged commit 793cca1 into master Jun 21, 2019
@pdyraga pdyraga deleted the relay-request-callback branch June 21, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadowfiend Shadowfiend Shadowfiend left review comments

@mhluongo mhluongo mhluongo left review comments

@liamzebedee liamzebedee liamzebedee left review comments

@pdyraga pdyraga pdyraga approved these changes

Assignees

@pdyraga pdyraga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contract callback functionality for relay request
5 participants
@ngrinkevich @Shadowfiend @mhluongo @liamzebedee @pdyraga