This repository has been archived by the owner on May 22, 2023. It is now read-only.
Fixed from address for contract call options #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated dependencies to the most recent versions containing a fix to from address in call options for generated contract bindings. From address should be set to the signer address. We had a bug and it was set to the destination contract address.
nkuba
reviewed
Apr 29, 2020
| @@ -18,8 +18,8 @@ require ( | |||
| github.com/gogo/protobuf v1.3.1 | |||
| github.com/google/gofuzz v1.1.0 | |||
| github.com/ipfs/go-log v0.0.1 | |||
| github.com/keep-network/keep-common v0.3.0-rc | |||
| github.com/keep-network/keep-core v0.14.0-rc | |||
| github.com/keep-network/keep-common v0.3.0-rc.0.20200427145435-e24eeb9599e4 | |||
There was a problem hiding this comment.
Do we want to update this reference to a commit merging the actual PR to the master? keep-network/keep-common@07d2a79
There was a problem hiding this comment.
Or maybe we should provide a new tag in keep-common?
There was a problem hiding this comment.
We'll do a new tag before keep-core release and then we'll update. We have to do the same in keep-core.
nkuba
approved these changes
Apr 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated dependencies to the most recent versions of
keep-coreandkeep-commoncontaining keep-network/keep-common#33 with a fix toFromaddress in call options for generated contract bindings.Tested with clients and smoke test, everything works as expected.