This repository has been archived by the owner on May 22, 2023. It is now read-only.
Check operator balance before status update #570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`MinimumKeyGenerationBalance` config option allows to specify the minimum operator ETH balance to participate in new keeps.
Check the operator balance against the `MinimumKeyGenerationBalance` config property before updating the status in the sortition pool. This should prevent the operator being selected to new signing groups in case when the operator doesn't have enough funds to take part in the key generation protocol.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #551
This pull request introduces a new
MinimumKeyGenerationBalanceconfig property which defines a minimum WEI balance below which the operator should not participate in new keeps. The main motivation is to avoid spending funds during the key generation protocol and hold them for signatures requests to mitigate the risk of bonds seizing by not having enough ETH to submit requested signatures to the chain.Technically, the aforementioned behavior is achieved by checking the current operator's balance against the
MinimumKeyGenerationBalancevalue and aborting the operator status update in the sortition pool in case the current balance is below the minimum. Not updating the operator status will force the sortition pool to omit the operator during group selection.