This repository has been archived by the owner on May 22, 2023. It is now read-only.
Update locked sha3 version to 1.2.6 #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated version of sha3 in package-lock.json file to 1.2.6, as the previous version was erroring node-gyp in npm install on Node 14.
michalinacienciala
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
I've tested it locally, looking good! I created a PR with accompanying changes in the local-setup: keep-network/local-setup#105.
nkuba
added a commit
to keep-network/local-setup
that referenced
this pull request
Aug 4, 2021
No longer install `sha3` in a separate step Up until recently, the `package-lock.json` in `keep-ecdsa/solidity` had the `sha3` package configured in the `1.2.3` version. This version wasn't working correctly with the Node.js 14.x which we're using for E2E testing. This meant we needed to upgrade the `sha3` to a higher version. Previously we've been doing that in the `install-e2e-test.sh` script, but recently we upgraded the version (to `1.2.6`) directly in the `keep-ecdsa/solidity/package-lock.json` file, making the `npm install --save-dev sha3` step in the `install-e2e-test.sh` script obsolete. Ref: keep-network/keep-ecdsa#878
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we updated version of
sha3inpackage-lock.jsonfile to1.2.6, as the previous version was erroring node-gyp in npm install on Node 14.