Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

added is_query to handle estimate fee #866

Merged

Conversation

apoorvsadana
Copy link
Collaborator

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Bugfix
  • Feature

What is the current behavior?

Estimate fee with version 0x100000000000000000000000000000001 doesn't work. Starknet-rs has added support for it and this PR integrates it.

Resolves: #646

What is the new behavior?

  • Estimate fee works correctly now
  • Once dev/query_tx_version is merged in starknet-rs, I will update the packages in this PR and we can merge

Does this introduce a breaking change?

No

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 81.08% and project coverage change: +0.08 🎉

Comparison is base (9db8569) 41.74% compared to head (5a8b447) 41.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
+ Coverage   41.74%   41.83%   +0.08%     
==========================================
  Files          86       86              
  Lines       10689    10717      +28     
  Branches    10689    10717      +28     
==========================================
+ Hits         4462     4483      +21     
- Misses       5661     5668       +7     
  Partials      566      566              
Impacted Files Coverage Δ
...rates/primitives/starknet/src/transaction/utils.rs 30.43% <70.00%> (+30.43%) ⬆️
crates/primitives/starknet/src/transaction/mod.rs 81.52% <71.42%> (-0.30%) ⬇️
...rates/primitives/starknet/src/transaction/types.rs 40.21% <75.00%> (+0.62%) ⬆️
crates/client/rpc-core/src/tests.rs 95.91% <100.00%> (+0.14%) ⬆️
crates/client/rpc-core/src/utils.rs 66.54% <100.00%> (+0.25%) ⬆️
...s/primitives/starknet/src/crypto/commitment/mod.rs 92.77% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@EvolveArt EvolveArt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would probably remove calculate_transaction_version_from_u8 and add TransactionVersion::ONE, TransactionVersion::ZERO

@apoorvsadana apoorvsadana changed the title added is query to handle estimate fee added is_query to handle estimate fee Jul 13, 2023
@apoorvsadana apoorvsadana changed the title added is_query to handle estimate fee added is_query to handle estimate fee Jul 13, 2023
Copy link
Collaborator

@EvolveArt EvolveArt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EvolveArt EvolveArt merged commit cd02fdd into keep-starknet-strange:main Jul 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support for estimateFee version
2 participants