Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

CI: added wasm to test #948

Merged
merged 10 commits into from
Aug 18, 2023
Merged

Conversation

joaopereira12
Copy link
Contributor

Pull Request type

  • Testing
  • CI

What is the current behavior?

CI doesn´t run nodes with --execution=wasm

Resolves: #906

What is the new behavior?

CI can run the JS integration tests with --execution=wasm

Does this introduce a breaking change?

No

@joaopereira12 joaopereira12 marked this pull request as draft July 31, 2023 15:42
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fa98fe9) 43.37% compared to head (31d3990) 43.37%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #948   +/-   ##
=======================================
  Coverage   43.37%   43.37%           
=======================================
  Files          88       88           
  Lines       10820    10820           
  Branches    10820    10820           
=======================================
  Hits         4693     4693           
  Misses       5594     5594           
  Partials      533      533           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaopereira12 joaopereira12 marked this pull request as ready for review July 31, 2023 16:14
@d-roak
Copy link
Collaborator

d-roak commented Aug 1, 2023

passing this to draft until the integration testing is fixed

@d-roak d-roak marked this pull request as draft August 1, 2023 20:29
@tdelabro tdelabro marked this pull request as ready for review August 16, 2023 08:36
@tdelabro
Copy link
Collaborator

@d-roak is this ready to be merged now that the CI has been fixed?

@d-roak
Copy link
Collaborator

d-roak commented Aug 16, 2023

@d-roak is this ready to be merged now that the CI has been fixed?

Need to double-check once we merge my PR (on main) into this one

Copy link
Collaborator

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-roak d-roak merged commit 1833549 into keep-starknet-strange:main Aug 18, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testing/CI: the CI should also test the wasm environment
3 participants