This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #948 +/- ##
=======================================
Coverage 43.37% 43.37%
=======================================
Files 88 88
Lines 10820 10820
Branches 10820 10820
=======================================
Hits 4693 4693
Misses 5594 5594
Partials 533 533 ☔ View full report in Codecov by Sentry. |
tdelabro
reviewed
Jul 31, 2023
joaopereira12
force-pushed
the
ci_changes
branch
from
August 1, 2023 18:29
b3d03f3
to
51a5513
Compare
passing this to draft until the integration testing is fixed |
@d-roak is this ready to be merged now that the CI has been fixed? |
Need to double-check once we merge my PR (on main) into this one |
d-roak
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
CI doesn´t run nodes with --execution=wasm
Resolves: #906
What is the new behavior?
CI can run the JS integration tests with --execution=wasm
Does this introduce a breaking change?
No