Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Implement OP_MIN opcode #17

Closed
b-j-roberts opened this issue Jul 24, 2024 · 2 comments
Closed

[feat] Implement OP_MIN opcode #17

b-j-roberts opened this issue Jul 24, 2024 · 2 comments
Assignees
@ptisserand
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@b-j-roberts
Copy link
Contributor

Implement the OP_MIN opcode using the opcodeMin reference implementation from btcd

References

Guide on how to add an opcode in shinigami
@b-j-roberts b-j-roberts added enhancement New feature or request good first issue Good for newcomers labels Jul 24, 2024
@ptisserand
Copy link
Contributor

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I'm a cairo developer and I'm interested in learning more about Bitcoin script VM

How I plan on tackling this issue

I will look at btcsuite implementation and implement this opcode in cairo with associated tests

@b-j-roberts
Copy link
Contributor Author

Glad to have you on the project @ptisserand !

@ptisserand ptisserand mentioned this issue Jul 25, 2024
Closed
ptisserand added a commit to ptisserand/shinigami that referenced this issue Jul 25, 2024
@ptisserand
feat: keep-starknet-strange#17 add OP_MIN opcode
4554c3f
ptisserand added a commit to ptisserand/shinigami that referenced this issue Jul 25, 2024
@ptisserand
feat: keep-starknet-strange#17 add OP_MIN opcode
7d1b350
@ptisserand ptisserand mentioned this issue Jul 25, 2024
Merged
4 tasks
ptisserand added a commit to ptisserand/shinigami that referenced this issue Jul 26, 2024
@ptisserand
feat: keep-starknet-strange#17 add OP_MIN opcode
8262f67
b-j-roberts added a commit that referenced this issue Jul 29, 2024
@ptisserand @b-j-roberts
[feat] OP_[2..16] and OP_MIN implementation (#33)
256c2da 
* feat: #5 add `OP_[2..16]` opcodes

* feat: #17 add `OP_MIN` opcode

---------

Co-authored-by: Brandon Roberts <brandonjroberts22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptisserand ptisserand

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptisserand @b-j-roberts