Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: strict encoding boolean #254

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: strict encoding boolean #254

merged 1 commit into from
Oct 8, 2024

Conversation

bloomingpeach
Copy link
Contributor

  • issue #
  • follows contribution guide
  • code change includes tests

This fixes all tests in sig_der_failing_tests.json. fix the bug in the last PR #251, where I seperate strict_encoding and der_sig flag.

@vercel Vercel
Copy link

vercel bot commented Oct 8, 2024

@bloomingpeach is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

b-j-roberts
b-j-roberts approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Nice work as always!

@b-j-roberts b-j-roberts merged commit 9fadb36 into keep-starknet-strange:main Oct 8, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-roberts b-j-roberts b-j-roberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bloomingpeach @b-j-roberts