-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolves first failing bitcoin-core test #281
fix: resolves first failing bitcoin-core test #281
Conversation
@SoarinSkySagar is attempting to deploy a commit to the keep-starknet-strange Team on Vercel. A member of the Team first needs to authorize it. |
Hi @b-j-roberts, please review the PR |
Have you tried running the core test script and make sure no new tests are failing? @SoarinSkySagar |
Yes, I made sure of that @bloomingpeach |
you should run
|
done @bloomingpeach! |
Nice! You have fixed ten more tests, really good job! |
LGTM, waiting for @b-j-roberts' review |
@bloomingpeach Thank you for helping review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets go, great work! Only a handful of tests remaining!
code change includes testsEarlier, the first test in the
.tests/script_tests_failing.json
was failing due to it receiving the wrong type of error message. the expected error wasSCRIPT_ERR_SIG_DER
but it gotSIG_HASHTYPE
error instead. This PR fixes that issue.