Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolves first failing bitcoin-core test #281

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

SoarinSkySagar
Copy link
Contributor

@SoarinSkySagar SoarinSkySagar commented Nov 11, 2024

Earlier, the first test in the .tests/script_tests_failing.json was failing due to it receiving the wrong type of error message. the expected error was SCRIPT_ERR_SIG_DER but it got SIG_HASHTYPE error instead. This PR fixes that issue.

Copy link

vercel bot commented Nov 11, 2024

@SoarinSkySagar is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

@SoarinSkySagar SoarinSkySagar marked this pull request as ready for review November 11, 2024 14:25
@SoarinSkySagar
Copy link
Contributor Author

Hi @b-j-roberts, please review the PR

@bloomingpeach
Copy link
Contributor

Have you tried running the core test script and make sure no new tests are failing? @SoarinSkySagar

@SoarinSkySagar
Copy link
Contributor Author

Have you tried running the core test script and make sure no new tests are failing? @SoarinSkySagar

Yes, I made sure of that @bloomingpeach

@bloomingpeach
Copy link
Contributor

you should run bash ./tests/run-core-tests.sh to update the script_tests_failing.json and script_tests_passing.json

Have you tried running the core test script and make sure no new tests are failing? @SoarinSkySagar

Yes, I made sure of that @bloomingpeach

@SoarinSkySagar
Copy link
Contributor Author

you should run bash ./tests/run-core-tests.sh to update the script_tests_failing.json and script_tests_passing.json

done @bloomingpeach!

@bloomingpeach
Copy link
Contributor

Nice! You have fixed ten more tests, really good job!

@bloomingpeach
Copy link
Contributor

LGTM, waiting for @b-j-roberts' review

@b-j-roberts
Copy link
Contributor

@bloomingpeach Thank you for helping review!

Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go, great work! Only a handful of tests remaining!

@b-j-roberts b-j-roberts merged commit 64361d1 into keep-starknet-strange:main Nov 13, 2024
3 of 4 checks passed
@SoarinSkySagar SoarinSkySagar deleted the error_1 branch November 19, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants