Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Generator separator breaks ui #360

Closed
Ironwally opened this issue Apr 12, 2024 · 5 comments
Closed

Password Generator separator breaks ui #360

Ironwally opened this issue Apr 12, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@Ironwally
Copy link

Ironwally commented Apr 12, 2024

Description
The Gui of the password generator is completely filled with a password and scrolling is no longer possible making it impossible to change the password generator settings anymore.

How to reproduce
Steps to reproduce the behavior:

  1. Open App
  2. Open Password Generator
  3. Open Password Generator Settings
  4. Go to Passphrase mode
  5. Put amount of words on max
  6. Set separator to something very VERY long. (long enough for the password to cover your entire screen), remember it is repeated the amount of words - 1
  7. Voilà, your screen should now be filled with one big password and the setting to change this can no longer be reached.

Expected behavior
No matter how big password, screen is still scrollable and therefore settings to change it are still reachable.

Screenshots
IMG_1903
IMG_1904

Environment:

  • Device: [e.g. iPhone Xs Max]
  • OS: [e.g. iOS17.3.1]
  • App Version: [e.g. 1.54.147]
@Ironwally Ironwally added the bug Something isn't working label Apr 12, 2024
@keepassium
Copy link
Owner

Set separator to something very VERY long.

But why?

@Ironwally
Copy link
Author

I wanted to see how far I could push the entropy

@Ironwally
Copy link
Author

Maybe the possibility to reset the password generator settings from the app settings, could work as an easy fix agains any problems that come up with the password generator.

@keepassium
Copy link
Owner

Thank you for the clarification. As a general rule, "just avoid holding it in that way" :)

I have also limited the max height of the password label to 50%. This is more of a guardrail, though. The text gets truncated without any indication, which may cause confusion. Doing this properly would require either a scrollbar or a gradient, but this is too much complexity for such a rare edge case. Basically, the app will just leave enough of controls visible that the user can return to more sensible settings :)

@Ironwally
Copy link
Author

thanks for the fix 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants