Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove span element from ignored nodes #2418

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

varjolintu
Copy link
Member

@varjolintu varjolintu commented Dec 21, 2024

Removes the element from ignored nodes list. Input fields can be used inside of those elements.

Fixes #2396.

Testing strategy

Manually:
Go to https://magyarorszag.hu/, switch to English (upper right corner), then click "Login" (on the left side). On the appearing page, choose "Client gate". The appearing page now displays in Hungarian, but the upper input field is the username, the lower is the password field. These fields are completely undetected.

Improved Input Field Detection must be enabled for https://idp.gov.hu/*.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@varjolintu varjolintu merged commit 0c1aa0e into develop Dec 21, 2024
@varjolintu varjolintu deleted the fix/remove_span_from_ignored_nodes branch December 21, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants