-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creates a window to show multiple credentials for HTTP authentication #782
Conversation
Screenshot? |
Great idea! |
Thanks for the PR. This makes lot easier to get rid of some extra popup code in the future. One thing I'm not sure of: now the dialog is centered by the screen. Should it be centered to the browser window instead? |
Good ideia, since the native dialog does that... |
df28a99
to
cc8e736
Compare
@furious That dialog is way too small. It should show at least 8-10 credentials, just to make sure. Is there any way to resize it dynamically? |
…tion, also better UI if have a lot of credentials
cc8e736
to
65a13e3
Compare
@varjolintu I don't know a good way to calculate and dynamically resize the dialog, any suggestions? |
Well. If it's possible to know the height of one item on list before showing, it would make things easier, and you could adjust the window accordingly. EDIT: Or just remove the lines you added to popup.css which makes the window scrollable instead. |
Accidental close? |
Well, this is probably my last effort for this pull request, I hope it meets the last requirements to be approved/merged. |
@furious Thanks for the update. Now it works great! |
798406d
to
6819844
Compare
What is preventing this PR to be finally merged into develop branch? |
@furious My laziness. I'll review this again to see everything's fine, and let's put this to the next release. |
Btw, the dialog doesn't disappear if user decides to "cancel" the process and just to go another page. Would it be easy to fix?
|
Any chance on getting this merged and fixing this separately? |
I had big troubles trying to rebase this PR. Lets continue at: #1064 |
I started using KeePassXC but was missing a feature from the Kee Vault extension, so I implemented it here.
This PR creates a popup window for multiple credentials on HTTP basic authentication requests, its more convenient than clicking on the extension icon to select one (which will still be there).
I've tested it a lot and I think is working fine, let me know if you find any problems.