Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce regex url capability to KeePassXC. #10291

Closed
calebsdaddy opened this issue Feb 11, 2024 · 2 comments
Closed

Re-introduce regex url capability to KeePassXC. #10291

calebsdaddy opened this issue Feb 11, 2024 · 2 comments

Comments

@calebsdaddy
Copy link

calebsdaddy commented Feb 11, 2024

Summary

Requesting regex be re-introduced as a feature for URL handling. The replacement for regex, "Browser Integration: Additional URLs" does not work as advertied. The below does not match as indicated as described in:

#3718 (comment)

My version is 2.7.6

https://sub1.domain.tld does NOT match with https://sub2.sub1.domain.tld
and
https://sub2.sub1.domain.tld does NOT match with https://host1.sub2.sub1.domain.tld

Context

I manage THOUSANDS of devices, frequently via IPMI. I can and have verified regex would allow me to have a single entry that would work for all my IPMI devices, however it has been removed and no longer works. I have verified that OTHER password managers WILL do regex without issue.

On Oct 29, 2019, yan12125 wrote in #1769 (comment)

Now there is #3558 for multiple URLs in KeePassXC. In case anyone else is using my branch, here is a patch to migrate from URL_ALT to officially-supported KP2A URLs. URL_REGEX attributes are dropped, though, as I don't use it in many entries and it's non-trivial to migrate them.

This is HIGHLY disrespectful. Just because a single user doesn't use them, doesn't mean a boatload of users would not. In addition, it is nowhere near trivial to migrate them considering I'd either need an entry for EVERY IPMI I access or one URL entry for over 2000 nodes I support and the current unusability of "Additional URLs".

@varjolintu
Copy link
Member

#9835 ?

@droidmonkey
Copy link
Member

droidmonkey commented Feb 11, 2024

This is a duplicate, and this means something else is happening:

https://sub1.domain.tld does NOT match with https://sub2.sub1.domain.tld and https://sub2.sub1.domain.tld does NOT match with https://host1.sub2.sub1.domain.tld

This should absolutely work. Unless you enabled "Only return best matching credentials" but even then it should work. The website you are testing on might have an iframe that is using a different url. The extension gives you a notice on which domain it was trying to use to find credentials.

For the record, we never had regex matching for urls. So nothing was removed.

@droidmonkey droidmonkey closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants