Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for URL wildcards and exact URL #9835

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

varjolintu
Copy link
Member

@varjolintu varjolintu commented Sep 12, 2023

Adds support for URL wildcards and exact URL if the address is wrapped insinde " e.g. "https://example.com/page.php". Without wildcards, URL's are handled normally with the old/current implementation.

The wildcards can be used freely, and some example addresses are:

  • https://*.example.com/page/*
  • https://192.*.168.1/
  • subdomain.of.*.example.com/page/*/login

Fixes #3718.

Testing strategy

Manually, and added automatic tests.

Type of change

  • ✅ New feature (change that adds functionality)

@varjolintu varjolintu added this to the v2.8.0 milestone Sep 12, 2023
@varjolintu varjolintu changed the title Ddd support for URL wildcards and exact URL Add support for URL wildcards and exact URL Sep 12, 2023
@varjolintu varjolintu marked this pull request as draft September 12, 2023 07:20
@mfrakka
Copy link

mfrakka commented Sep 14, 2023

Hi, I received the invitation to test the new feature.
I downloaded tha AppImage 2.8.0-snapshot but seems that nothing is changed about wilcards in url, if I add a wildcard the field in the "Browser integration" appear as aan invalid url.

What I'm doing wrong?

Regards.

@varjolintu
Copy link
Member Author

Hi, I received the invitation to test the new feature. I downloaded tha AppImage 2.8.0-snapshot but seems that nothing is changed about wilcards in url, if I add a wildcard the field in the "Browser integration" appear as aan invalid url.

What I'm doing wrong?

Regards.

You'll have to download the original branch and compile it yourself. There's no snapshots for separate commits or PR's.

@mfrakka
Copy link

mfrakka commented Sep 14, 2023

Hi, I received the invitation to test the new feature. I downloaded tha AppImage 2.8.0-snapshot but seems that nothing is changed about wilcards in url, if I add a wildcard the field in the "Browser integration" appear as aan invalid url.
What I'm doing wrong?
Regards.

You'll have to download the original branch and compile it yourself. There's no snapshots for separate commits or PR's.

Ah OK.
Excuse my ignorance...

@mfrakka
Copy link

mfrakka commented Sep 15, 2023

Hi, I was able to download and compile it in RHEL, it seems to work!
Thank you. I'll do better tests sooner as possible.

@mfrakka
Copy link

mfrakka commented Oct 2, 2023

Hi, I'm trying to build an AppImage to test the app on my daily computer but after a successful build on Arch Linux I can' t get any .AppImage file in the source directory.

Configure with "-DKEEPASSXC_DIST_TYPE=AppImage" switch is not enough?

@droidmonkey
Copy link
Member

Use the release-tool

@mfrakka
Copy link

mfrakka commented Oct 2, 2023

I tried but I got this error:

[matteo@arch keepassxc]$ ./release-tool build -v develop --appimage
KeePassXC Release Preparation Helper
Copyright (C) 2021 KeePassXC Team https://keepassxc.org/

[ INFO ] Checking out release tag 'develop'...
[ INFO ] Creating output directory...
[ INFO ] Creating source tarball...
[ INFO ] Creating build directory...
[ INFO ] Configuring sources...
[ INFO ] Configuring build...
CMake Deprecation Warning at CMakeLists.txt:17 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.

Update the VERSION argument value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.

-- Found Git HEAD Revision: cd7a53a

-- Setting up build for KeePassXC v2.8.0

-- Including translations...

-- Using asciidoctor: /usr/bin/asciidoctor
-- Enabled features:

  • Auto-Type, Automatic password typing
  • Networking, Compile KeePassXC with network access code (e.g. for downloading website icons)
  • KeePassXC-Browser, Browser integration with KeePassXC-Browser
  • SSHAgent, SSH agent integration compatible with KeeAgent
  • KeeShare, Sharing integration with KeeShare
  • YubiKey, YubiKey HMAC-SHA1 challenge-response
  • UpdateCheck, Automatic update checking
  • FdoSecrets, Implement freedesktop.org Secret Storage Spec server side API.

-- Disabled features:

-- Configuring done (0.1s)
-- Generating done (0.1s)
-- Build files have been written to: /home/matteo/keepassxc
[ INFO ] Compiling sources...
make: *** No targets specified and no makefile found. Stop.
[ INFO ] Checking out original branch...
[ INFO ] Leaving source directory...
[ ERROR ] Error occurred!

Maybe I missed some steps...

@varjolintu
Copy link
Member Author

varjolintu commented Dec 4, 2023

TODO: Check if using https://doc.qt.io/qt-6/qregularexpression.html#wildcardToRegularExpression is preferred after Qt6 upgrade. Qt5 does not support https://doc.qt.io/qt-6/qregularexpression.html#WildcardConversionOption-enum.

@droidmonkey
Copy link
Member

Oh nice that will likely replace one of our tools functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Browser pr: new feature Pull request that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow limited wildcard matching for Browser Integration URLs
4 participants